r17415 - gnucash/branches/gda-dev2/src/business/business-core/sql - Don't put quotes around address pieces. This stops an empty string from

Phil Longstaff plongstaff at cvs.gnucash.org
Sun Jul 27 09:01:59 EDT 2008


Author: plongstaff
Date: 2008-07-27 09:01:58 -0400 (Sun, 27 Jul 2008)
New Revision: 17415
Trac: http://svn.gnucash.org/trac/changeset/17415

Modified:
   gnucash/branches/gda-dev2/src/business/business-core/sql/gnc-address-sql.c
Log:
Don't put quotes around address pieces.  This stops an empty string from
being put into the db as ''.



Modified: gnucash/branches/gda-dev2/src/business/business-core/sql/gnc-address-sql.c
===================================================================
--- gnucash/branches/gda-dev2/src/business/business-core/sql/gnc-address-sql.c	2008-07-27 12:58:52 UTC (rev 17414)
+++ gnucash/branches/gda-dev2/src/business/business-core/sql/gnc-address-sql.c	2008-07-27 13:01:58 UTC (rev 17415)
@@ -167,7 +167,6 @@
     gchar* s;
     QofAccessFunc getter;
 	const GncSqlColumnTableEntry* subtable_row;
-	gchar* buf;
 
 	g_return_if_fail( be != NULL );
 	g_return_if_fail( obj_name != NULL );
@@ -180,8 +179,6 @@
     if( G_VALUE_TYPE(&value) != 0 ) {
         addr = g_value_get_object( &value );
 		for( subtable_row = col_table; subtable_row->col_name != NULL; subtable_row++ ) {
-    		buf = g_strdup_printf( "%s_%s", table_row->col_name, subtable_row->col_name );
-			
 			subfield_value = g_new0( GValue, 1 );
 			if( subtable_row->gobj_param_name != NULL ) {
 				g_object_get( addr, subtable_row->gobj_param_name, &s, NULL );
@@ -189,16 +186,13 @@
     			getter = gnc_sql_get_getter( GNC_ID_ADDRESS, subtable_row );
     			s = (gchar*)(*getter)( addr, NULL );
 			}
+        	g_value_init( subfield_value, G_TYPE_STRING );
     		if( s ) {
-        		g_value_init( subfield_value, G_TYPE_STRING );
-        		g_value_take_string( subfield_value,
-									g_strdup_printf( "'%s'", s ) );
+        		g_value_set_string( subfield_value, s );
 			} else {
-				g_value_init( subfield_value, G_TYPE_STRING );
 				g_value_set_string( subfield_value, "NULL" );
 			}
 			(*pList) = g_slist_append( (*pList), subfield_value );
-			g_free( buf );
 		}
     }
 }



More information about the gnucash-changes mailing list