r17238 - gnucash/branches/gda-dev2/src - 1) In add_gvalue_int_to_slist(), simplify handling when the value is

[Phil Longstaff]

Author: plongstaff
Date: 2008-06-19 21:01:29 -0400 (Thu, 19 Jun 2008)
New Revision: 17238
Trac: http://svn.gnucash.org/trac/changeset/17238

Modified:
   gnucash/branches/gda-dev2/src/backend/sql/gnc-backend-sql.c
   gnucash/branches/gda-dev2/src/business/business-core/sql/gnc-owner-sql.c
Log:
1) In add_gvalue_int_to_slist(), simplify handling when the value is
retrieved from the object by g_object_get_property().
2) Set owner_guid column type to 'char(32)', and don't surround the value by
single quotes.



Modified: gnucash/branches/gda-dev2/src/backend/sql/gnc-backend-sql.c
===================================================================
--- gnucash/branches/gda-dev2/src/backend/sql/gnc-backend-sql.c	2008-06-20 00:05:02 UTC (rev 17237)
+++ gnucash/branches/gda-dev2/src/backend/sql/gnc-backend-sql.c	2008-06-20 01:01:29 UTC (rev 17238)
@@ -1087,15 +1087,15 @@
 	g_return_if_fail( pList != NULL );
 
 	value = g_new0( GValue, 1 );
+    g_value_init( value, G_TYPE_INT );
 
 	if( table_row->gobj_param_name != NULL ) {
-		g_object_get( pObject, table_row->gobj_param_name, &int_value, NULL );
+		g_object_get_property( pObject, table_row->gobj_param_name, value );
 	} else {
     	i_getter = (IntAccessFunc)gnc_sql_get_getter( obj_name, table_row );
     	int_value = (*i_getter)( pObject );
+    	g_value_set_int( value, int_value );
 	}
-    g_value_init( value, G_TYPE_INT );
-    g_value_set_int( value, int_value );
 
 	(*pList) = g_slist_append( (*pList), value );
 }
@@ -1767,8 +1767,12 @@
 	g_return_if_fail( pObject != NULL );
 	g_return_if_fail( table_row != NULL );
 
-    getter = (NumericGetterFunc)gnc_sql_get_getter( obj_name, table_row );
-    n = (*getter)( pObject );
+//	if( table_row->gobj_param_name != NULL ) {
+//		g_object_get( pObject, table_row->gobj_param_name, &s, NULL );
+//	} else {
+    	getter = (NumericGetterFunc)gnc_sql_get_getter( obj_name, table_row );
+    	n = (*getter)( pObject );
+//	}
 
     num_value = g_new0( GValue, 1 );
     g_value_init( num_value, G_TYPE_INT64 );

Modified: gnucash/branches/gda-dev2/src/business/business-core/sql/gnc-owner-sql.c
===================================================================
--- gnucash/branches/gda-dev2/src/business/business-core/sql/gnc-owner-sql.c	2008-06-20 00:05:02 UTC (rev 17237)
+++ gnucash/branches/gda-dev2/src/business/business-core/sql/gnc-owner-sql.c	2008-06-20 01:01:29 UTC (rev 17238)
@@ -161,6 +161,7 @@
 	info->name = buf;
 	info->type_name = gnc_sql_connection_get_column_type_name( be->conn,
 										G_TYPE_STRING, GUID_ENCODING_LENGTH );
+	info->size = GUID_ENCODING_LENGTH;
 	info->is_primary_key = (table_row->flags & COL_PKEY) ? TRUE : FALSE;
 	info->null_allowed = (table_row->flags & COL_NNUL) ? FALSE : TRUE;
 	*pList = g_list_append( *pList, info );
@@ -234,7 +235,7 @@
 			guid = qof_instance_get_guid( inst );
     		if( guid != NULL ) {
         		(void)guid_to_string_buff( guid, guid_buf );
-        		g_value_take_string( subfield_value, g_strdup_printf( "'%s'", guid_buf ) );
+        		g_value_take_string( subfield_value, g_strdup_printf( "%s", guid_buf ) );
     		} else {
 				g_value_set_string( subfield_value, "NULL" );
 			}