AUDIT: r17018 - gnucash/trunk/src/import-export/qif-import - QIF import: Update error handling used when looking up the user's documentation

Charles Day cedayiv at cvs.gnucash.org
Sat Mar 8 16:16:17 EST 2008


Author: cedayiv
Date: 2008-03-08 16:16:17 -0500 (Sat, 08 Mar 2008)
New Revision: 17018
Trac: http://svn.gnucash.org/trac/changeset/17018

Modified:
   gnucash/trunk/src/import-export/qif-import/druid-qif-import.c
Log:
QIF import: Update error handling used when looking up the user's documentation
page preference in gconf. Use existing #define for gconf section and add one
for name. This is an update to r16976.
BP


Modified: gnucash/trunk/src/import-export/qif-import/druid-qif-import.c
===================================================================
--- gnucash/trunk/src/import-export/qif-import/druid-qif-import.c	2008-03-08 21:05:53 UTC (rev 17017)
+++ gnucash/trunk/src/import-export/qif-import/druid-qif-import.c	2008-03-08 21:16:17 UTC (rev 17018)
@@ -55,6 +55,7 @@
 
 #define DRUID_QIF_IMPORT_CM_CLASS "druid-qif-import"
 #define GCONF_SECTION "dialogs/import/qif"
+#define GCONF_NAME_SHOW_DOC "show_doc"
 
 #define PREV_ROW "prev_row"
 
@@ -2212,15 +2213,15 @@
 
   /* Get the user's preference for showing documentation pages. */
   retval->show_doc_pages = 
-    gnc_gconf_get_bool("dialogs/import/qif", "show_doc", &err);
+    gnc_gconf_get_bool(GCONF_SECTION, GCONF_NAME_SHOW_DOC, &err);
   if (err != NULL) {
-    /* The setting can't be found. */
-    printf("QIF import: gnc_gconf_get_bool error: %s\n", err->message);
+    g_warning("QIF import: gnc_gconf_get_bool error: %s\n", err->message);
     g_error_free(err);
 
     /* Show documentation pages by default. */
-    printf("QIF import: Couldn't get show_doc setting from gconf.\n");
-    printf("QIF import: Documentation pages will be shown by default.\n");
+    g_warning("QIF import: Couldn't get %s setting from gconf.\n",
+              GCONF_NAME_SHOW_DOC);
+    g_warning("QIF import: Documentation pages will be shown by default.\n");
     retval->show_doc_pages = TRUE;
   }
 



More information about the gnucash-changes mailing list