AUDIT: r17891 - gnucash/trunk/src/import-export - Bug #552275, #434944: Fix generic import skipped transactions

[Christian Stimming]

Author: cstim
Date: 2009-02-10 16:16:35 -0500 (Tue, 10 Feb 2009)
New Revision: 17891
Trac: http://svn.gnucash.org/trac/changeset/17891

Modified:
   gnucash/trunk/src/import-export/import-main-matcher.c
Log:
Bug #552275, #434944: Fix generic import skipped transactions

gnc_import_TransInfo_delete() was defined but never called!
This led to a memory leak, and erroneous behaviour.

 Bug 552275 - Cancelling OFX Import Still Adds Entries
 Bug 434944 - Refused transactions from import appear in register

Patch by Alan Jenkins <alan-jenkins at tuffmail.co.uk>
BP

Modified: gnucash/trunk/src/import-export/import-main-matcher.c
===================================================================
--- gnucash/trunk/src/import-export/import-main-matcher.c	2009-02-10 21:16:29 UTC (rev 17890)
+++ gnucash/trunk/src/import-export/import-main-matcher.c	2009-02-10 21:16:35 UTC (rev 17891)
@@ -89,9 +89,23 @@
 
 void gnc_gen_trans_list_delete (GNCImportMainMatcher *info)
 {
+  GtkTreeModel *model;
+  GtkTreeIter iter;
+  GNCImportTransInfo *trans_info;
+
   if (info == NULL) 
     return;
 
+  model = gtk_tree_view_get_model(info->view);
+  if (gtk_tree_model_get_iter_first(model, &iter)) {
+    do {
+      gtk_tree_model_get(model, &iter,
+		         DOWNLOADED_COL_DATA, &trans_info,
+		         -1);
+      gnc_import_TransInfo_delete(trans_info);
+    } while (gtk_tree_model_iter_next (model, &iter));
+  }
+
   gnc_save_window_size(GCONF_SECTION, GTK_WINDOW(info->dialog));
   gnc_import_Settings_delete (info->user_settings);
   gtk_widget_destroy (GTK_WIDGET (info->dialog));