r17950 - gnucash/trunk/src/register/ledger-core - Register: Tweak some comments and slightly reorganize the register cleanup code for ease of reading.

Charles Day cedayiv at cvs.gnucash.org
Mon Feb 23 17:56:06 EST 2009


Author: cedayiv
Date: 2009-02-23 17:56:06 -0500 (Mon, 23 Feb 2009)
New Revision: 17950
Trac: http://svn.gnucash.org/trac/changeset/17950

Modified:
   gnucash/trunk/src/register/ledger-core/split-register.c
Log:
Register: Tweak some comments and slightly reorganize the register cleanup code for ease of reading.


Modified: gnucash/trunk/src/register/ledger-core/split-register.c
===================================================================
--- gnucash/trunk/src/register/ledger-core/split-register.c	2009-02-23 20:22:36 UTC (rev 17949)
+++ gnucash/trunk/src/register/ledger-core/split-register.c	2009-02-23 22:56:06 UTC (rev 17950)
@@ -2545,30 +2545,30 @@
 
    gnc_suspend_gui_refresh ();
 
-   /* be sure to destroy the "blank split" */
+   /* Destroy the transaction containing the "blank split", which was only
+    * created to support the area for entering a new transaction. Since the
+    * register is closing, this transaction is no longer needed. */
    if (blank_split != NULL)
    {
       gboolean was_open;
 
-      /* split destroy will automatically remove it
-       * from its parent account */
       blank_trans = xaccSplitGetParent (blank_split);
 
       DEBUG("blank_split=%p, blank_trans=%p, pending_trans=%p",
             blank_split, blank_trans, pending_trans);
 
-      /* Make sure we don't commit this below */
+      /* Destroying the transaction will automatically remove its splits. */
+      was_open = xaccTransIsOpen (blank_trans);
+      xaccTransDestroy (blank_trans);
+      if (was_open)
+        xaccTransCommitEdit (blank_trans);
+
+      /* Update the register info. */
       if (blank_trans == pending_trans)
       {
         info->pending_trans_guid = *guid_null ();
         pending_trans = NULL;
       }
-
-      was_open = xaccTransIsOpen (blank_trans);
-      xaccTransDestroy (blank_trans);
-      if (was_open)
-        xaccTransCommitEdit (blank_trans);
-
       info->blank_split_guid = *guid_null ();
       blank_split = NULL;
    }



More information about the gnucash-changes mailing list