r17835 - gnucash/trunk/src/backend/dbi - Do not determine and waste memory for {base, dir}name when sqlite3 driver cannot be loaded.

Andreas Köhler andi5 at cvs.gnucash.org
Sun Jan 18 17:57:34 EST 2009


Author: andi5
Date: 2009-01-18 17:57:34 -0500 (Sun, 18 Jan 2009)
New Revision: 17835
Trac: http://svn.gnucash.org/trac/changeset/17835

Modified:
   gnucash/trunk/src/backend/dbi/gnc-backend-dbi.c
Log:
Do not determine and waste memory for {base,dir}name when sqlite3 driver cannot be loaded.


Modified: gnucash/trunk/src/backend/dbi/gnc-backend-dbi.c
===================================================================
--- gnucash/trunk/src/backend/dbi/gnc-backend-dbi.c	2009-01-18 22:51:32 UTC (rev 17834)
+++ gnucash/trunk/src/backend/dbi/gnc-backend-dbi.c	2009-01-18 22:57:34 UTC (rev 17835)
@@ -160,9 +160,6 @@
 		return;
 	}
 
-	dirname = g_path_get_dirname( book_id );
-	basename = g_path_get_basename( book_id );
-
 	be->conn = dbi_conn_new( "sqlite3" );
 	if( be->conn == NULL ) {
 		PERR( "Unable to create sqlite3 dbi connection\n" );
@@ -170,6 +167,9 @@
 		LEAVE( " " );
 		return;
 	}
+
+	dirname = g_path_get_dirname( book_id );
+	basename = g_path_get_basename( book_id );
 	dbi_conn_error_handler( be->conn, error_fn, be );
 	dbi_conn_set_option( be->conn, "host", "localhost" );
 	dbi_conn_set_option( be->conn, "dbname", basename );



More information about the gnucash-changes mailing list