r18147 - gnucash/trunk/src/backend/sql - Fix memory leaks

Phil Longstaff plongstaff at code.gnucash.org
Sun Jun 21 12:14:04 EDT 2009


Author: plongstaff
Date: 2009-06-21 12:14:04 -0400 (Sun, 21 Jun 2009)
New Revision: 18147
Trac: http://svn.gnucash.org/trac/changeset/18147

Modified:
   gnucash/trunk/src/backend/sql/gnc-backend-sql.c
Log:
Fix memory leaks


Modified: gnucash/trunk/src/backend/sql/gnc-backend-sql.c
===================================================================
--- gnucash/trunk/src/backend/sql/gnc-backend-sql.c	2009-06-21 16:11:08 UTC (rev 18146)
+++ gnucash/trunk/src/backend/sql/gnc-backend-sql.c	2009-06-21 16:14:04 UTC (rev 18147)
@@ -2368,7 +2368,7 @@
 	(void)g_string_append( sql, ")" );
 
 	stmt = gnc_sql_connection_create_statement_from_sql( be->conn, sql->str );
-	(void)g_string_free( sql, FALSE );
+	(void)g_string_free( sql, TRUE );
 
 	return stmt;
 }
@@ -2435,7 +2435,7 @@
 	stmt = gnc_sql_connection_create_statement_from_sql( be->conn, sql->str );
 	gnc_sql_statement_add_where_cond( stmt, obj_name, pObject, &table[0], (GValue*)(values->data) );
 	g_slist_free( values );
-	(void)g_string_free( sql, FALSE );
+	(void)g_string_free( sql, TRUE );
 
 	return stmt;
 }
@@ -2447,7 +2447,6 @@
                         const GncSqlColumnTableEntry* table )
 {
 	GncSqlStatement* stmt;
-	GString* sql;
     GncSqlColumnTypeHandler* pHandler;
 	GSList* list = NULL;
 	gchar* sqlbuf;
@@ -2459,10 +2458,8 @@
 	g_return_val_if_fail( table != NULL, NULL );
 
 	sqlbuf = g_strdup_printf( "DELETE FROM %s ", table_name );
-	sql = g_string_new( sqlbuf );
+	stmt = gnc_sql_connection_create_statement_from_sql( be->conn, sqlbuf );
 	g_free( sqlbuf );
-	stmt = gnc_sql_connection_create_statement_from_sql( be->conn, sql->str );
-	(void)g_string_free( sql, FALSE );
 
     /* WHERE */
     pHandler = get_handler( table );



More information about the gnucash-changes mailing list