r18314 - gnucash/trunk/src - Fix bug 595015 - compiler warnings for missing printf format specs, gcc 4.2.1

Phil Longstaff plongstaff at code.gnucash.org
Mon Sep 14 19:38:57 EDT 2009


Author: plongstaff
Date: 2009-09-14 19:38:56 -0400 (Mon, 14 Sep 2009)
New Revision: 18314
Trac: http://svn.gnucash.org/trac/changeset/18314

Modified:
   gnucash/trunk/src/bin/gnucash-bin.c
   gnucash/trunk/src/business/business-gnome/dialog-date-close.c
   gnucash/trunk/src/business/business-gnome/dialog-invoice.c
   gnucash/trunk/src/business/business-gnome/dialog-order.c
   gnucash/trunk/src/business/business-gnome/search-owner.c
   gnucash/trunk/src/business/dialog-tax-table/dialog-tax-table.c
   gnucash/trunk/src/engine/Recurrence.c
   gnucash/trunk/src/gnome-search/search-account.c
   gnucash/trunk/src/gnome-utils/dialog-commodity.c
   gnucash/trunk/src/gnome/dialog-print-check.c
   gnucash/trunk/src/gnome/dialog-sx-editor.c
   gnucash/trunk/src/gnome/dialog-sx-from-trans.c
   gnucash/trunk/src/gnome/druid-loan.c
   gnucash/trunk/src/gnome/druid-stock-split.c
   gnucash/trunk/src/gnome/gnc-plugin-page-budget.c
   gnucash/trunk/src/gnome/gnc-plugin-page-register.c
   gnucash/trunk/src/gnome/gnc-plugin-page-sx-list.c
   gnucash/trunk/src/gnome/gnc-split-reg.c
   gnucash/trunk/src/html/gnc-html-gtkhtml.c
   gnucash/trunk/src/html/gnc-html-webkit.c
   gnucash/trunk/src/import-export/aqbanking/dialog-ab-trans.c
   gnucash/trunk/src/import-export/aqbanking/druid-ab-initial.c
   gnucash/trunk/src/import-export/csv/gnc-csv-import.c
   gnucash/trunk/src/import-export/csv/gnc-csv-model.c
   gnucash/trunk/src/import-export/qif-import/druid-qif-import.c
   gnucash/trunk/src/report/report-gnome/gnc-plugin-page-report.c
Log:
Fix bug 595015 -  compiler warnings for missing printf format specs, gcc 4.2.1

Patch by David Reiser


Modified: gnucash/trunk/src/bin/gnucash-bin.c
===================================================================
--- gnucash/trunk/src/bin/gnucash-bin.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/bin/gnucash-bin.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -387,7 +387,7 @@
     scm_c_eval_string("(gnc:price-quotes-install-sources)");
 
     if (!gnc_quote_source_fq_installed()) {
-        g_print(_("No quotes retrieved. Finance::Quote isn't "
+        g_print("%s", _("No quotes retrieved. Finance::Quote isn't "
                   "installed properly.\n"));
         goto fail;
     }

Modified: gnucash/trunk/src/business/business-gnome/dialog-date-close.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-date-close.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/business/business-gnome/dialog-date-close.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -69,13 +69,13 @@
     acc = gnc_account_sel_get_account( GNC_ACCOUNT_SEL(ddc->acct_combo) );
 
     if (!acc) {
-      gnc_error_dialog (ddc->dialog,
+      gnc_error_dialog (ddc->dialog, "%s",
 			_("No Account selected.  Please try again."));
       return;
     }
 
     if (xaccAccountGetPlaceholder (acc)) {
-      gnc_error_dialog (ddc->dialog,
+      gnc_error_dialog (ddc->dialog, "%s",
 			_("Placeholder account selected.  Please try again."));
       return;
     }

Modified: gnucash/trunk/src/business/business-gnome/dialog-invoice.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-invoice.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/business/business-gnome/dialog-invoice.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -344,7 +344,7 @@
   gnc_owner_get_owner (iw->owner_choice, &(iw->owner));
   res = gncOwnerGetName (&(iw->owner));
   if (res == NULL || safe_strcmp (res, "") == 0) {
-    gnc_error_dialog (iw_get_window(iw),
+    gnc_error_dialog (iw_get_window(iw), "%s",
 		      /* Translators: In this context,
 		       * 'Billing information' maps to the
 		       * label in the frame and means
@@ -627,7 +627,7 @@
   /* Check that there is at least one Entry */
   invoice = iw_get_invoice (iw);
   if (gncInvoiceGetEntries (invoice) == NULL) {
-    gnc_error_dialog (iw_get_window(iw),
+    gnc_error_dialog (iw_get_window(iw), "%s",
 		      _("The Invoice must have at least one Entry."));
     return;
   }
@@ -636,14 +636,14 @@
 
   /* Make sure that the invoice has a positive balance */
   if (gnc_numeric_negative_p(gncInvoiceGetTotal(invoice))) {
-    gnc_error_dialog(iw_get_window(iw),
+    gnc_error_dialog(iw_get_window(iw), "%s",
 		     _("You may not post an invoice with a negative total value."));
     return;
   }
 
   if (iw->total_cash_label &&
       gnc_numeric_negative_p(gncInvoiceGetTotalOf(invoice, GNC_PAYMENT_CASH))) {
-    gnc_error_dialog(iw_get_window(iw),
+    gnc_error_dialog(iw_get_window(iw), "%s",
 		     _("You may not post an expense voucher with a negative total cash value."));
     return;
   }

Modified: gnucash/trunk/src/business/business-gnome/dialog-order.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-order.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/business/business-gnome/dialog-order.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -161,7 +161,7 @@
   /* Check the ID */
   res = gtk_entry_get_text (GTK_ENTRY (ow->id_entry));
   if (safe_strcmp (res, "") == 0) {
-    gnc_error_dialog (ow->dialog,
+    gnc_error_dialog (ow->dialog, "%s",
 		      _("The Order must be given an ID."));
     return FALSE;
   }
@@ -170,7 +170,7 @@
   gnc_owner_get_owner (ow->owner_choice, &(ow->owner));
   res = gncOwnerGetName (&(ow->owner));
   if (res == NULL || safe_strcmp (res, "") == 0) {
-    gnc_error_dialog (ow->dialog,
+    gnc_error_dialog (ow->dialog, "%s",
 		      _("You need to supply Billing Information."));
     return FALSE;
   }
@@ -264,7 +264,7 @@
 
   /* Check that there is at least one Entry */
   if (gncOrderGetEntries (order) == NULL) {
-    gnc_error_dialog (ow->dialog,
+    gnc_error_dialog (ow->dialog, "%s",
 		      _("The Order must have at least one Entry."));
     return;
   }

Modified: gnucash/trunk/src/business/business-gnome/search-owner.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/search-owner.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/business/business-gnome/search-owner.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -160,7 +160,7 @@
   priv = GNC_SEARCH_OWNER_GET_PRIVATE(fi);
   if (priv->owner.owner.undefined == NULL) {
     valid = FALSE;
-    gnc_error_dialog (NULL, _("You have not selected an owner"));
+    gnc_error_dialog (NULL, "%s", _("You have not selected an owner"));
   }
 
   /* XXX */

Modified: gnucash/trunk/src/business/dialog-tax-table/dialog-tax-table.c
===================================================================
--- gnucash/trunk/src/business/dialog-tax-table/dialog-tax-table.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/business/dialog-tax-table/dialog-tax-table.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -583,7 +583,7 @@
     return;
   }
 
-  if (gnc_verify_dialog (ttw->dialog, FALSE,
+  if (gnc_verify_dialog (ttw->dialog, FALSE, "%s",
 			 _("Are you sure you want to delete this entry?"))) {
     /* Ok, let's remove it */
     gnc_suspend_gui_refresh ();

Modified: gnucash/trunk/src/engine/Recurrence.c
===================================================================
--- gnucash/trunk/src/engine/Recurrence.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/engine/Recurrence.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -531,7 +531,7 @@
         // and purposes this will be fine.
         multiplier = recurrenceGetMultiplier(r);
     }
-    g_string_printf(buf, _("Weekly"));
+    g_string_printf(buf, "%s", _("Weekly"));
     if (multiplier > 1)
     {
         /* translators: %u is the recurrence multipler, i.e. this
@@ -584,7 +584,7 @@
 
     if (g_list_length(rs) == 0)
     {
-        g_string_printf(buf, _("None"));
+        g_string_printf(buf, "%s", _("None"));
         goto rtn;
     }
 
@@ -605,7 +605,7 @@
                           recurrenceGetMultiplier(first), recurrenceGetMultiplier(second));
             }
 
-            g_string_printf(buf, _("Semi-monthly"));
+            g_string_printf(buf, "%s", _("Semi-monthly"));
             g_string_append_printf(buf, " ");
             if (recurrenceGetMultiplier(first) > 1)
             {
@@ -631,10 +631,10 @@
         switch (recurrenceGetPeriodType(r))
         {
         case PERIOD_ONCE: {
-            g_string_printf(buf, _("Once"));
+            g_string_printf(buf, "%s", _("Once"));
         } break;
         case PERIOD_DAY: {
-            g_string_printf(buf, _("Daily"));
+            g_string_printf(buf, "%s", _("Daily"));
             if (multiplier > 1)
             {
                 /* translators: %u is the recurrence multiplier. */
@@ -647,7 +647,7 @@
         case PERIOD_MONTH:
         case PERIOD_END_OF_MONTH:
         case PERIOD_LAST_WEEKDAY: {
-            g_string_printf(buf, _("Monthly"));
+            g_string_printf(buf, "%s", _("Monthly"));
             if (multiplier > 1)
             {
                 /* translators: %u is the recurrence multiplier. */
@@ -661,7 +661,7 @@
             g_string_printf(buf, "@fixme: nth weekday not handled");
         } break;
         case PERIOD_YEAR: {
-            g_string_printf(buf, _("Yearly"));
+            g_string_printf(buf, "%s", _("Yearly"));
             if (multiplier > 1)
             {
                 /* translators: %u is the recurrence multiplier. */

Modified: gnucash/trunk/src/gnome/dialog-print-check.c
===================================================================
--- gnucash/trunk/src/gnome/dialog-print-check.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/dialog-print-check.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -545,7 +545,7 @@
         dialog = gtk_message_dialog_new(GTK_WINDOW(pcd->dialog),
                                         GTK_DIALOG_DESTROY_WITH_PARENT,
                                         GTK_MESSAGE_ERROR,
-                                        GTK_BUTTONS_CLOSE,
+                                        GTK_BUTTONS_CLOSE, "%s", 
                                         _("Cannot save check format file."));
         gtk_message_dialog_format_secondary_text(GTK_MESSAGE_DIALOG(dialog),
                                                  "%s", error->message);
@@ -1078,7 +1078,7 @@
             dialog = gtk_message_dialog_new
                 (GTK_WINDOW(pcd->dialog),
                  GTK_DIALOG_DESTROY_WITH_PARENT,
-                 GTK_MESSAGE_ERROR, GTK_BUTTONS_CLOSE,
+                 GTK_MESSAGE_ERROR, GTK_BUTTONS_CLOSE, "%s", 
                  _("There is a duplicate check format file."));
             gtk_message_dialog_format_secondary_text
                 (GTK_MESSAGE_DIALOG(dialog),

Modified: gnucash/trunk/src/gnome/dialog-sx-editor.c
===================================================================
--- gnucash/trunk/src/gnome/dialog-sx-editor.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/dialog-sx-editor.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -765,7 +765,7 @@
                 GTK_TOGGLE_BUTTON(sxed->notifyOpt) );
 
         if (((ttVarCount > 0) || multi_commodity) && autocreateState) {
-            gnc_warning_dialog(sxed->dialog,
+            gnc_warning_dialog(sxed->dialog, "%s", 
                                _("Scheduled Transactions with variables "
                                  "cannot be automatically created."));
             return FALSE;
@@ -774,7 +774,7 @@
         /* Fix for part of Bug#121740 -- auto-create transactions are
          * only valid if there's actually a transaction to create. */
         if ( autocreateState && splitCount == 0 ) {
-            gnc_warning_dialog( sxed->dialog,
+            gnc_warning_dialog(sxed->dialog, "%s", 
                                 _("Scheduled Transactions without a template "
                                   "transaction cannot be automatically created.") );
             return FALSE;

Modified: gnucash/trunk/src/gnome/dialog-sx-from-trans.c
===================================================================
--- gnucash/trunk/src/gnome/dialog-sx-from-trans.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/dialog-sx-from-trans.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -550,7 +550,7 @@
   else
   {
     if ( sx_error == SXFTD_ERRNO_UNBALANCED_XACTION ) {
-            gnc_error_dialog( gnc_ui_get_toplevel(), 
+            gnc_error_dialog( gnc_ui_get_toplevel(), "%s",  
                               _( "The Scheduled Transaction is unbalanced. "
                                  "You are strongly encouraged to correct this situation." ) );
     }
@@ -769,7 +769,7 @@
   if ( (errno = sxftd_init( sxfti )) < 0 ) {
           if ( errno == SXFTD_ERRNO_OPEN_XACTION )
           {
-                  gnc_error_dialog( gnc_ui_get_toplevel(),
+                  gnc_error_dialog( gnc_ui_get_toplevel(), "%s", 
                                     _( "Cannot create a Scheduled Transaction "
                                        "from a Transaction currently "
                                        "being edited. Please Enter the "

Modified: gnucash/trunk/src/gnome/druid-loan.c
===================================================================
--- gnucash/trunk/src/gnome/druid-loan.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/druid-loan.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -1159,7 +1159,7 @@
 
         ldd->ld.primaryAcct = gnc_account_sel_get_account( ldd->prmAccountGAS );
         if ( ldd->ld.primaryAcct == NULL ) {
-                gnc_info_dialog( ldd->dialog,
+                gnc_info_dialog( ldd->dialog, "%s", 
                                  _("Please select a valid loan account.") );
                 return TRUE;
         } 
@@ -1246,7 +1246,7 @@
                 ldd->ld.escrowAcct =
                         gnc_account_sel_get_account( ldd->optEscrowGAS );
                 if ( ldd->ld.escrowAcct == NULL ) {
-                        gnc_info_dialog( ldd->dialog,
+                        gnc_info_dialog( ldd->dialog, "%s", 
                                          _("Please select a valid "
                                            "Escrow Account.") );
                         return TRUE;
@@ -1312,21 +1312,21 @@
         ldd->ld.repFromAcct =
                 gnc_account_sel_get_account( ldd->repAssetsFromGAS );
         if ( ldd->ld.repFromAcct == NULL ) {
-                gnc_info_dialog( ldd->dialog,
+                gnc_info_dialog( ldd->dialog, "%s", 
                                  _("Please select a valid \"from\" account."));
                 return TRUE;
         }
         ldd->ld.repPriAcct =
                 gnc_account_sel_get_account( ldd->repPrincToGAS );
         if ( ldd->ld.repPriAcct == NULL ) {
-                gnc_info_dialog( ldd->dialog,
+                gnc_info_dialog( ldd->dialog, "%s", 
                                  _("Please select a valid \"to\" account.") );
                 return TRUE;
         }
         ldd->ld.repIntAcct =
                 gnc_account_sel_get_account( ldd->repIntToGAS );
         if ( ldd->ld.repIntAcct == NULL ) {
-                gnc_info_dialog( ldd->dialog,
+                gnc_info_dialog( ldd->dialog, "%s", 
                                  _("Please select a valid "
                                    "\"interest\" account.") );
                 return TRUE;
@@ -1531,7 +1531,7 @@
         if ( rod->specSrcAcctP ) {
                 rod->from = gnc_account_sel_get_account( ldd->payAcctFromGAS );
                 if ( rod->from == NULL ) {
-                        gnc_info_dialog( ldd->dialog,
+                        gnc_info_dialog( ldd->dialog, "%s", 
                                          _("Please select a valid "
                                            "\"from\" account.") );
                         return TRUE;
@@ -1540,7 +1540,7 @@
 
         rod->to   = gnc_account_sel_get_account( ldd->payAcctToGAS );
         if ( rod->to == NULL ) {
-                gnc_info_dialog( ldd->dialog,
+                gnc_info_dialog( ldd->dialog, "%s", 
                                  _("Please select a valid "
                                    "\"to\" account.") );
                 return TRUE;

Modified: gnucash/trunk/src/gnome/druid-stock-split.c
===================================================================
--- gnucash/trunk/src/gnome/druid-stock-split.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/druid-stock-split.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -482,7 +482,7 @@
     pdb = gnc_book_get_pricedb (book);
 
     if (!gnc_pricedb_add_price (pdb, price))
-      gnc_error_dialog (info->window, _("Error adding price."));
+      gnc_error_dialog (info->window, "%s", _("Error adding price."));
 
     gnc_price_unref (price);
   }
@@ -785,7 +785,7 @@
 
   if (fill_account_list (info, initial) == 0)
   {
-    gnc_warning_dialog (parent, _("You don't have any stock accounts with balances!"));
+    gnc_warning_dialog (parent, "%s", _("You don't have any stock accounts with balances!"));
     gnc_close_gui_component_by_data (DRUID_STOCK_SPLIT_CM_CLASS, info);
     return;
   }

Modified: gnucash/trunk/src/gnome/gnc-plugin-page-budget.c
===================================================================
--- gnucash/trunk/src/gnome/gnc-plugin-page-budget.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/gnc-plugin-page-budget.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -907,7 +907,7 @@
         dialog = gtk_message_dialog_new (
             GTK_WINDOW(gnc_plugin_page_get_window(GNC_PLUGIN_PAGE(page))),
             GTK_DIALOG_DESTROY_WITH_PARENT | GTK_DIALOG_MODAL,
-            GTK_MESSAGE_INFO, GTK_BUTTONS_CLOSE,
+            GTK_MESSAGE_INFO, GTK_BUTTONS_CLOSE, "%s", 
             _("You must select at least one account to estimate."));
         gtk_dialog_run (GTK_DIALOG(dialog));
         gtk_widget_destroy(dialog);

Modified: gnucash/trunk/src/gnome/gnc-plugin-page-register.c
===================================================================
--- gnucash/trunk/src/gnome/gnc-plugin-page-register.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/gnc-plugin-page-register.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -2062,7 +2062,7 @@
   if (xaccTransHasSplitsInState(trans, VREC))
     return;
   if (xaccTransHasReconciledSplits(trans) || xaccTransHasSplitsInState(trans, CREC)) {
-    gnc_error_dialog(NULL, _("You cannot void a transaction with reconciled or cleared splits."));
+    gnc_error_dialog(NULL, "%s", _("You cannot void a transaction with reconciled or cleared splits."));
     return;
   }
 
@@ -2129,7 +2129,7 @@
     return;
 
   if (xaccTransGetReversedBy(trans)) {
-      gnc_error_dialog(gnc_plugin_page_get_window(GNC_PLUGIN_PAGE(page)),
+      gnc_error_dialog(gnc_plugin_page_get_window(GNC_PLUGIN_PAGE(page)), "%s",
         _("A reversing entry has already been created for this transaction."));
       return;
   }

Modified: gnucash/trunk/src/gnome/gnc-plugin-page-sx-list.c
===================================================================
--- gnucash/trunk/src/gnome/gnc-plugin-page-sx-list.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/gnc-plugin-page-sx-list.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -592,7 +592,7 @@
        multiple SXs be deleted as well? Ideally, the number of
        to-be-deleted SXs should be mentioned here; see
        dialog-sx-since-last-run.c:807 */
-    if (gnc_verify_dialog(NULL, FALSE, _("Do you really want to delete this scheduled transaction?")))
+    if (gnc_verify_dialog(NULL, FALSE, "%s", _("Do you really want to delete this scheduled transaction?")))
     {
         g_list_foreach(to_delete, (GFunc)_destroy_sx, NULL);
     }

Modified: gnucash/trunk/src/gnome/gnc-split-reg.c
===================================================================
--- gnucash/trunk/src/gnome/gnc-split-reg.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome/gnc-split-reg.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -867,7 +867,7 @@
     return;
 
   if (xaccTransGetReversedBy(trans)) {
-      gnc_error_dialog(gsr->window,
+      gnc_error_dialog(gsr->window, "%s",
         _("A reversing entry has already been created for this transaction."));
       return;
   }

Modified: gnucash/trunk/src/gnome-search/search-account.c
===================================================================
--- gnucash/trunk/src/gnome-search/search-account.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome-search/search-account.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -167,7 +167,7 @@
   priv = _PRIVATE(fi);
   if (priv->selected_accounts == NULL && fi->how ) {
     valid = FALSE;
-    gnc_error_dialog (NULL, _("You have not selected any accounts"));
+    gnc_error_dialog (NULL, "%s", _("You have not selected any accounts"));
   }
 
   /* XXX */

Modified: gnucash/trunk/src/gnome-utils/dialog-commodity.c
===================================================================
--- gnucash/trunk/src/gnome-utils/dialog-commodity.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/gnome-utils/dialog-commodity.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -1207,7 +1207,7 @@
       gnc_commodity_commit_edit(c);
       return TRUE;
     }
-    gnc_warning_dialog(w->dialog,
+    gnc_warning_dialog(w->dialog, "%s", 
 		       _("You may not create a new national currency."));
     return FALSE;
   }
@@ -1220,7 +1220,7 @@
 
     if ((!w->edit_commodity && c) ||
         (w->edit_commodity && c && (c != w->edit_commodity))) {
-      gnc_warning_dialog (w->dialog, _("That commodity already exists."));
+      gnc_warning_dialog (w->dialog, "%s",  _("That commodity already exists."));
       g_free(namespace);
       return FALSE;
     }
@@ -1262,7 +1262,7 @@
     c = gnc_commodity_table_insert(gnc_get_current_commodities(), c);
   }
   else {
-    gnc_warning_dialog(w->dialog,
+    gnc_warning_dialog(w->dialog, "%s", 
 		       _("You must enter a non-empty \"Full name\", "
 			 "\"Symbol/abbreviation\", "
 			 "and \"Type\" for the commodity."));

Modified: gnucash/trunk/src/html/gnc-html-gtkhtml.c
===================================================================
--- gnucash/trunk/src/html/gnc-html-gtkhtml.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/html/gnc-html-gtkhtml.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -380,7 +380,7 @@
 
 			if( !safe_strcmp( type, URL_TYPE_SECURE ) ) {
 				if( !https_allowed() ) {
-					gnc_error_dialog( priv->base.parent,
+					gnc_error_dialog( priv->base.parent,"%s",
                             _("Secure HTTP access is disabled. "
                               "You can enable it in the Network section of "
                               "the Preferences dialog."));
@@ -389,7 +389,7 @@
 			}
 
 			if( !http_allowed() ) {
-				gnc_error_dialog( priv->base.parent,
+				gnc_error_dialog( priv->base.parent,"%s",
                           _("Network HTTP access is disabled. "
                             "You can enable it in the Network section of "
                             "the Preferences dialog."));
@@ -698,7 +698,7 @@
 		do {
 			if( safe_strcmp( type, URL_TYPE_SECURE ) == 0 ) {
 				if( !https_allowed() ) {
-					gnc_error_dialog( priv->base.parent,
+					gnc_error_dialog( priv->base.parent,"%s",
 									_("Secure HTTP access is disabled. "
 									"You can enable it in the Network section of "
 									"the Preferences dialog.") );
@@ -708,7 +708,7 @@
 
 			if( safe_strcmp( type, URL_TYPE_HTTP ) == 0 ) {
 				if( !http_allowed() ) {
-					gnc_error_dialog( priv->base.parent,
+					gnc_error_dialog( priv->base.parent,"%s",
 									_("Network HTTP access is disabled. "
 									"You can enable it in the Network section of "
 									"the Preferences dialog.") );

Modified: gnucash/trunk/src/html/gnc-html-webkit.c
===================================================================
--- gnucash/trunk/src/html/gnc-html-webkit.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/html/gnc-html-webkit.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -416,7 +416,7 @@
 
 			if( !safe_strcmp( type, URL_TYPE_SECURE ) ) {
 				if( !https_allowed() ) {
-					gnc_error_dialog( priv->base.parent,
+					gnc_error_dialog( priv->base.parent, "%s",
                             _("Secure HTTP access is disabled. "
                               "You can enable it in the Network section of "
                               "the Preferences dialog."));
@@ -425,7 +425,7 @@
 			}
 
 			if( !http_allowed() ) {
-				gnc_error_dialog( priv->base.parent,
+				gnc_error_dialog( priv->base.parent,"%s",
                           _("Network HTTP access is disabled. "
                             "You can enable it in the Network section of "
                             "the Preferences dialog."));
@@ -736,7 +736,7 @@
 		do {
 			if( safe_strcmp( type, URL_TYPE_SECURE ) == 0 ) {
 				if( !https_allowed() ) {
-					gnc_error_dialog( priv->base.parent,
+					gnc_error_dialog( priv->base.parent,"%s",
 									_("Secure HTTP access is disabled. "
 									"You can enable it in the Network section of "
 									"the Preferences dialog.") );
@@ -746,7 +746,7 @@
 
 			if( safe_strcmp( type, URL_TYPE_HTTP ) == 0 ) {
 				if( !http_allowed() ) {
-					gnc_error_dialog( priv->base.parent,
+					gnc_error_dialog( priv->base.parent,"%s",
 									_("Network HTTP access is disabled. "
 									"You can enable it in the Network section of "
 									"the Preferences dialog.") );

Modified: gnucash/trunk/src/import-export/aqbanking/dialog-ab-trans.c
===================================================================
--- gnucash/trunk/src/import-export/aqbanking/dialog-ab-trans.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/import-export/aqbanking/dialog-ab-trans.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -863,7 +863,7 @@
         gtk_tree_model_foreach(GTK_TREE_MODEL(td->template_list_store),
                                find_templ_helper, &data);
         if (data.pointer) {
-            gnc_error_dialog(dialog,
+            gnc_error_dialog(dialog, "%s",
                              _("A template with the given name already exists.  "
                                "Please enter another name."));
             continue;

Modified: gnucash/trunk/src/import-export/aqbanking/druid-ab-initial.c
===================================================================
--- gnucash/trunk/src/import-export/aqbanking/druid-ab-initial.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/import-export/aqbanking/druid-ab-initial.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -453,7 +453,7 @@
                       "value: %d. The called program was \"%s\".\n",
                       exit_status, deferred_info->wizard_path);
             gnc_error_dialog
-                (info->window,
+                (info->window, "%s",
                  _("The external program \"AqBanking Setup Wizard\" failed "
                    "to run successfully because the "
                    "additional software \"Qt\" was not found.  "
@@ -472,7 +472,7 @@
                       "value: %d. The called program was \"%s\".\n",
                       exit_status, deferred_info->wizard_path);
             gnc_error_dialog
-                (info->window,
+                (info->window, "%s",
                  _("The external program \"AqBanking Setup Wizard\" failed "
                    "to run successfully.  Online Banking can only be setup "
                    "if this wizard has run successfully.  "

Modified: gnucash/trunk/src/import-export/csv/gnc-csv-import.c
===================================================================
--- gnucash/trunk/src/import-export/csv/gnc-csv-import.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/import-export/csv/gnc-csv-import.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -208,7 +208,7 @@
        gnc_csv_parse(preview->parse_data, FALSE, &error))
     {
       /* If it fails, change back to the old encoding. */
-      gnc_error_dialog(NULL, _("Invalid encoding selected"));
+      gnc_error_dialog(NULL, "%s", _("Invalid encoding selected"));
       preview->encoding_selected_called = FALSE;
       go_charmap_sel_set_encoding(selector, previous_encoding);
       return;

Modified: gnucash/trunk/src/import-export/csv/gnc-csv-model.c
===================================================================
--- gnucash/trunk/src/import-export/csv/gnc-csv-model.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/import-export/csv/gnc-csv-model.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -431,7 +431,7 @@
     /* TODO Handle file opening errors more specifically,
      * e.g. inexistent file versus no read permission. */
     parse_data->raw_str.begin = NULL;
-    g_set_error(error, 0, GNC_CSV_FILE_OPEN_ERR, _("File opening failed."));
+    g_set_error(error, 0, GNC_CSV_FILE_OPEN_ERR, "%s", _("File opening failed."));
     return 1;
   }
 
@@ -445,7 +445,7 @@
                                 "UTF-8", NULL);
   if(guess_enc == NULL)
   {
-    g_set_error(error, 0, GNC_CSV_ENCODING_ERR, _("Unknown encoding."));
+    g_set_error(error, 0, GNC_CSV_ENCODING_ERR, "%s", _("Unknown encoding."));
     return 1;
   }
 
@@ -454,7 +454,7 @@
   gnc_csv_convert_encoding(parse_data, guess_enc, error);
   if(parse_data->file_str.begin == NULL)
   {
-    g_set_error(error, 0, GNC_CSV_ENCODING_ERR, _("Unknown encoding."));
+    g_set_error(error, 0, GNC_CSV_ENCODING_ERR, "%s", _("Unknown encoding."));
     return 1;
   }
   else

Modified: gnucash/trunk/src/import-export/qif-import/druid-qif-import.c
===================================================================
--- gnucash/trunk/src/import-export/qif-import/druid-qif-import.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/import-export/qif-import/druid-qif-import.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -683,9 +683,9 @@
 
   /* Validate the chosen filename. */
   if (strlen(path_to_load) == 0)
-    gnc_error_dialog(wind->window, _("Please select a file to load."));
+    gnc_error_dialog(wind->window, "%s", _("Please select a file to load."));
   else if (g_access(path_to_load, R_OK) < 0)
-    gnc_error_dialog(wind->window,
+    gnc_error_dialog(wind->window, "%s",
                      _("File not found or read permission denied. "
                        "Please select another file."));
   else
@@ -696,7 +696,7 @@
     if (scm_call_2(qif_file_loaded,
                    scm_makfrom0str(path_to_load),
                    wind->imported_files) == SCM_BOOL_T)
-      gnc_error_dialog(wind->window,
+      gnc_error_dialog(wind->window, "%s",
                        _("That QIF file is already loaded. "
                          "Please select another file."));
     else
@@ -840,7 +840,7 @@
                      _( "A bug was detected while reading the QIF file."));
     gnc_progress_dialog_set_sub(wind->load_progress, _("Failed"));
     gnc_progress_dialog_reset_value(wind->load_progress);
-    gnc_error_dialog(wind->window,
+    gnc_error_dialog(wind->window, "%s",
                      _( "A bug was detected while reading the QIF file."));
     /* FIXME: How should we request that the user report this problem? */
 
@@ -917,7 +917,7 @@
                      _( "A bug was detected while parsing the QIF file."));
     gnc_progress_dialog_set_sub(wind->load_progress, _("Failed"));
     gnc_progress_dialog_reset_value(wind->load_progress);
-    gnc_error_dialog(wind->window,
+    gnc_error_dialog(wind->window, "%s",
                      _( "A bug was detected while parsing the QIF file."));
     /* FIXME: How should we request that the user report this problem? */
 
@@ -1387,7 +1387,7 @@
 
   g_return_val_if_fail(wind->selected_file != SCM_BOOL_F, FALSE);
   if (!acct_name || acct_name[0] == 0) {
-    gnc_warning_dialog(wind->window, _("You must enter an account name."));
+    gnc_warning_dialog(wind->window, "%s", _("You must enter an account name."));
     return TRUE;
   }
   else {
@@ -2067,20 +2067,20 @@
   const gchar *mnemonic  = gtk_entry_get_text(GTK_ENTRY(qpage->mnemonic_entry));
 
   if (!name || (name[0] == 0)) {
-    gnc_warning_dialog(wind->window,
+    gnc_warning_dialog(wind->window, "%s",
      _("Enter a name or short description, such as \"Red Hat Stock\"."));
     g_free(namespace);
     return TRUE;
   }
   else if (!mnemonic || (mnemonic[0] == 0)) {
-    gnc_warning_dialog(wind->window,
+    gnc_warning_dialog(wind->window, "%s",
      _("Enter the ticker symbol or other well known abbreviation, such as"
        " \"RHT\". If there isn't one, or you don't know it, create your own."));
     g_free(namespace);
     return TRUE;
   }
   else if (!namespace || (namespace[0] == 0)) {
-    gnc_warning_dialog(wind->window,
+    gnc_warning_dialog(wind->window, "%s",
      _("Select the exchange on which the symbol is traded, or select the"
        " type of investment (such as FUND for mutual funds.) If you don't"
        " see your exchange or an appropriate investment type, you can"
@@ -2100,7 +2100,7 @@
   if (gnc_commodity_namespace_is_iso(namespace) &&
       !gnc_commodity_table_lookup(table, namespace, mnemonic))
   {
-    gnc_warning_dialog(wind->window,
+    gnc_warning_dialog(wind->window, "%s",
                        _("You must enter an existing national "
                          "currency or enter a different type."));
 
@@ -2636,7 +2636,7 @@
                      _( "A bug was detected while converting the QIF data."));
     gnc_progress_dialog_set_sub(wind->convert_progress, _("Failed"));
     gnc_progress_dialog_reset_value(wind->convert_progress);
-    gnc_error_dialog(wind->window,
+    gnc_error_dialog(wind->window, "%s",
                      _( "A bug was detected while converting the QIF data."));
     /* FIXME: How should we request that the user report this problem? */
 
@@ -2706,7 +2706,7 @@
                      _( "A bug was detected while detecting duplicates."));
     gnc_progress_dialog_set_sub(wind->convert_progress, _("Failed"));
     gnc_progress_dialog_reset_value(wind->convert_progress);
-    gnc_error_dialog(wind->window,
+    gnc_error_dialog(wind->window, "%s",
                      _( "A bug was detected while detecting duplicates."));
     /* FIXME: How should we request that the user report this problem? */
 
@@ -3027,7 +3027,7 @@
                                    wind->security_prefs),
                          SCM_EOL);
   if (scm_result == SCM_BOOL_F)
-    gnc_warning_dialog(wind->window,
+    gnc_warning_dialog(wind->window, "%s",
             _("GnuCash was unable to save your mapping preferences."));
 
   /* Open an account tab in the main window if one doesn't exist already. */

Modified: gnucash/trunk/src/report/report-gnome/gnc-plugin-page-report.c
===================================================================
--- gnucash/trunk/src/report/report-gnome/gnc-plugin-page-report.c	2009-09-14 23:28:12 UTC (rev 18313)
+++ gnucash/trunk/src/report/report-gnome/gnc-plugin-page-report.c	2009-09-14 23:38:56 UTC (rev 18314)
@@ -1471,7 +1471,7 @@
         result = gfec_apply(start_editor, scm_cons(priv->cur_report, SCM_EOL), 
                             error_handler);
         if (result == SCM_BOOL_F || result == SCM_UNDEFINED) {
-                gnc_warning_dialog(GTK_WIDGET(gnc_ui_get_toplevel()),
+                gnc_warning_dialog(GTK_WIDGET(gnc_ui_get_toplevel()), "%s", 
                                    _("There are no options for this report."));
         }
         else {



More information about the gnucash-changes mailing list