r18546 - gnucash/trunk/src/business/business-gnome - Bug #602091: Fix broken Due Bill Reminder in all non-C locales

[Christian Stimming]

Author: cstim
Date: 2010-01-04 16:06:57 -0500 (Mon, 04 Jan 2010)
New Revision: 18546
Trac: http://svn.gnucash.org/trac/changeset/18546

Modified:
   gnucash/trunk/src/business/business-gnome/dialog-invoice.c
Log:
Bug #602091: Fix broken Due Bill Reminder in all non-C locales

The Due Bill Reminder used the translated form of "Invoice" as
query string predicate, which can't work because the untranslated
string must be searched for.

Modified: gnucash/trunk/src/business/business-gnome/dialog-invoice.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-invoice.c	2010-01-04 20:21:22 UTC (rev 18545)
+++ gnucash/trunk/src/business/business-gnome/dialog-invoice.c	2010-01-04 21:06:57 UTC (rev 18546)
@@ -2588,7 +2588,7 @@
   /* we want to find all invoices where:
    *      invoice -> is_posted == TRUE
    * AND  invoice -> lot -> is_closed? == FALSE
-   * AND  invoice -> type != _("Invoice")
+   * AND  invoice -> type != "Invoice"
    * AND  invoice -> due >= (today - days_in_advance)
    */
 
@@ -2598,7 +2598,10 @@
   gncQueryAddBooleanMatch (q, g_slist_prepend(g_slist_prepend(NULL, LOT_IS_CLOSED),
 					      INVOICE_POST_LOT), FALSE, QUERY_AND);
 
-  pred_data = gncQueryStringPredicate (COMPARE_NEQ, _("Invoice"),
+  /* Watch out: Do *not* translate the string "Invoice" here because
+     it must match the QofObject.type_label string exactly, which
+     implies it is used in untranslated form! */
+  pred_data = gncQueryStringPredicate (COMPARE_NEQ, "Invoice",
 				       STRING_MATCH_NORMAL, FALSE);
   gncQueryAddTerm (q, g_slist_prepend(NULL, INVOICE_TYPE), pred_data, QUERY_AND);