r21127 - gnucash/trunk/src/libqof/qof - Revert r21121, "Fix a weird include", and improve documentation of that.

Christian Stimming cstim at code.gnucash.org
Mon Aug 8 02:59:54 EDT 2011


Author: cstim
Date: 2011-08-08 02:59:54 -0400 (Mon, 08 Aug 2011)
New Revision: 21127
Trac: http://svn.gnucash.org/trac/changeset/21127

Modified:
   gnucash/trunk/src/libqof/qof/Makefile.am
   gnucash/trunk/src/libqof/qof/gnc-numeric.c
Log:
Revert r21121, "Fix a weird include", and improve documentation of that.

Note: The qofmath128 functions are used mostly here and almost
nowhere else. Hence, we inline the C code directly into here so
that the compiler can potentially inline the code as-is and speed
up the gnc-numeric.c functions.

Modified: gnucash/trunk/src/libqof/qof/Makefile.am
===================================================================
--- gnucash/trunk/src/libqof/qof/Makefile.am	2011-08-07 21:30:17 UTC (rev 21126)
+++ gnucash/trunk/src/libqof/qof/Makefile.am	2011-08-08 06:59:54 UTC (rev 21127)
@@ -15,7 +15,6 @@
 
 libgnc_qof_la_SOURCES =  \
    gnc-date.c        \
-   qofmath128.c      \
    gnc-numeric.c     \
    guid.c            \
    kvp-util.c        \
@@ -78,10 +77,13 @@
    qofquerycore-p.h \
    qofsession-p.h
 
+EXTRA_DIST = \
+  qofmath128.c
+
 if OS_WIN32
 libgnc_qof_la_SOURCES += qof-win32.c
 else
-EXTRA_DIST = qof-win32.c
+EXTRA_DIST += qof-win32.c
 endif
 
 ## For testing the qofmath128 routines

Modified: gnucash/trunk/src/libqof/qof/gnc-numeric.c
===================================================================
--- gnucash/trunk/src/libqof/qof/gnc-numeric.c	2011-08-07 21:30:17 UTC (rev 21126)
+++ gnucash/trunk/src/libqof/qof/gnc-numeric.c	2011-08-08 06:59:54 UTC (rev 21127)
@@ -34,7 +34,7 @@
 #include <string.h>
 
 #include "gnc-numeric.h"
-#include "qofmath128-p.h"
+#include "qofmath128.c" /* FIXME: Why is this C file included here?!? */
 
 /* static short module = MOD_ENGINE; */
 



More information about the gnucash-changes mailing list