r21676 - gnucash/trunk/src/engine/test - [Testing] Engine: Provide checked error messages to replace noted warnings

John Ralls jralls at code.gnucash.org
Sun Dec 4 19:08:01 EST 2011


Author: jralls
Date: 2011-12-04 19:08:01 -0500 (Sun, 04 Dec 2011)
New Revision: 21676
Trac: http://svn.gnucash.org/trac/changeset/21676

Modified:
   gnucash/trunk/src/engine/test/test-querynew.c
Log:
[Testing] Engine: Provide checked error messages to replace noted warnings


Much better for expected warnings to be tested for than to have a lead-in message saying that they're really OK.

Modified: gnucash/trunk/src/engine/test/test-querynew.c
===================================================================
--- gnucash/trunk/src/engine/test/test-querynew.c	2011-12-05 00:07:48 UTC (rev 21675)
+++ gnucash/trunk/src/engine/test/test-querynew.c	2011-12-05 00:08:01 UTC (rev 21676)
@@ -51,9 +51,18 @@
         { NULL },
     };
 
-    fprintf (stderr, "\tTesting the qof_query_object interface. \n"
-             "\tYou may see some \"** CRITICAL **\" messages, which you can safely ignore\n");
+    gchar *msg1 = "qof_class_get_parameter: assertion `obj_name' failed";
+    gchar *msg2 = "qof_class_get_parameter: assertion `parameter' failed";
+    gchar *logdomain = "qof";
+    guint loglevel = G_LOG_LEVEL_CRITICAL;
+    TestErrorStruct check1 = { loglevel, logdomain, msg1 };
+    TestErrorStruct check2 = { loglevel, logdomain, msg2 };
+    test_add_error (&check1);
+    test_add_error (&check2);
+    g_log_set_handler (logdomain, loglevel,
+		       (GLogFunc)test_list_handler, NULL);
 
+
     qof_class_register (TEST_MODULE_NAME, (QofSortFunc)test_sort, params);
 
     do_test (qof_class_get_parameter (TEST_MODULE_NAME, TEST_PARAM)
@@ -79,6 +88,7 @@
     	   "qof_class_get_default_sort");
       do_test (qof_class_get_default_sort (NULL) == NULL,
     	   "qof_class_get_default_sort (NULL)");*/
+    test_clear_error_list ();
 }
 
 static void test_query_core (void)



More information about the gnucash-changes mailing list