AUDIT: r21738 - gnucash/trunk/src - Replace no-op function force_account_dirty with qof_book_mark_dirty

[Geert Janssens]

Author: gjanssens
Date: 2011-12-18 13:06:08 -0500 (Sun, 18 Dec 2011)
New Revision: 21738
Trac: http://svn.gnucash.org/trac/changeset/21738

Modified:
   gnucash/trunk/src/import-export/aqbanking/gnc-ab-kvp.c
   gnucash/trunk/src/report/standard-reports/standard-reports.scm
Log:
Replace no-op function force_account_dirty with qof_book_mark_dirty
See bug #665998 for more details.
BP

Modified: gnucash/trunk/src/import-export/aqbanking/gnc-ab-kvp.c
===================================================================
--- gnucash/trunk/src/import-export/aqbanking/gnc-ab-kvp.c	2011-12-17 19:32:37 UTC (rev 21737)
+++ gnucash/trunk/src/import-export/aqbanking/gnc-ab-kvp.c	2011-12-18 18:06:08 UTC (rev 21738)
@@ -42,7 +42,6 @@
 /* This static indicates the debugging module that this .o belongs to.  */
 static QofLogModule log_module = G_LOG_DOMAIN;
 
-static void force_account_dirty(Account *acct);
 static kvp_frame *gnc_ab_get_account_kvp(const Account *a, gboolean create);
 static kvp_frame *gnc_ab_get_book_kvp(QofBook *b, gboolean create);
 
@@ -61,7 +60,7 @@
     kvp_value *value = kvp_value_new_string(id);
     xaccAccountBeginEdit(a);
     kvp_frame_set_slot_nc(frame, AB_ACCOUNT_ID, value);
-    force_account_dirty(a);
+    qof_book_mark_dirty(gnc_get_current_book());
     xaccAccountCommitEdit(a);
 }
 
@@ -80,7 +79,7 @@
     kvp_value *value = kvp_value_new_string(code);
     xaccAccountBeginEdit(a);
     kvp_frame_set_slot_nc(frame, AB_BANK_CODE, value);
-    force_account_dirty(a);
+    qof_book_mark_dirty(gnc_get_current_book());
     xaccAccountCommitEdit(a);
 }
 
@@ -99,7 +98,7 @@
     kvp_value *value = kvp_value_new_gint64(uid);
     xaccAccountBeginEdit(a);
     kvp_frame_set_slot_nc(frame, AB_ACCOUNT_UID, value);
-    force_account_dirty(a);
+    qof_book_mark_dirty(gnc_get_current_book());
     xaccAccountCommitEdit(a);
 }
 
@@ -118,7 +117,7 @@
     kvp_value *value = kvp_value_new_timespec(time);
     xaccAccountBeginEdit(a);
     kvp_frame_set_slot_nc(frame, AB_TRANS_RETRIEVAL, value);
-    force_account_dirty(a);
+    qof_book_mark_dirty(gnc_get_current_book());
     xaccAccountCommitEdit(a);
 }
 
@@ -141,20 +140,6 @@
     qof_book_commit_edit(b);
 }
 
-static void
-force_account_dirty(Account *acct)
-{
-    gchar *name = g_strdup(xaccAccountGetName(acct));
-    QofBook *book = gnc_get_current_book ();
-    /* This is necessary because modifying the KvpFrames doesn't mark
-     * accounts dirty, which means the changes wont be propagated to the
-     * backend.
-     */
-    qof_book_mark_dirty(book);
-    xaccAccountSetName(acct, name);
-    g_free(name);
-}
-
 static kvp_frame *
 gnc_ab_get_account_kvp(const Account *a, gboolean create)
 {

Modified: gnucash/trunk/src/report/standard-reports/standard-reports.scm
===================================================================
--- gnucash/trunk/src/report/standard-reports/standard-reports.scm	2011-12-17 19:32:37 UTC (rev 21737)
+++ gnucash/trunk/src/report/standard-reports/standard-reports.scm	2011-12-18 18:06:08 UTC (rev 21738)
@@ -118,6 +118,7 @@
     )
 )
 
+(gnc:debug "stdrpt-dir=" (gnc-path-get-stdreportsdir))
 (gnc:debug "dir-files=" (directory-files (gnc-path-get-stdreportsdir)))
 (gnc:debug "processed=" (process-file-list (directory-files (gnc-path-get-stdreportsdir))))
 (gnc:debug "report-list=" (get-report-list))