r20270 - gnucash/trunk/src - Minor code cleanup - remove includes from header if not necessary.

Christian Stimming cstim at code.gnucash.org
Thu Feb 10 16:48:58 EST 2011


Author: cstim
Date: 2011-02-10 16:48:58 -0500 (Thu, 10 Feb 2011)
New Revision: 20270
Trac: http://svn.gnucash.org/trac/changeset/20270

Modified:
   gnucash/trunk/src/app-utils/gnc-entry-quickfill.c
   gnucash/trunk/src/app-utils/gnc-entry-quickfill.h
   gnucash/trunk/src/gnome-utils/dialog-transfer.c
   gnucash/trunk/src/gnome-utils/dialog-transfer.h
Log:
Minor code cleanup - remove includes from header if not necessary.

Modified: gnucash/trunk/src/app-utils/gnc-entry-quickfill.c
===================================================================
--- gnucash/trunk/src/app-utils/gnc-entry-quickfill.c	2011-02-10 20:10:24 UTC (rev 20269)
+++ gnucash/trunk/src/app-utils/gnc-entry-quickfill.c	2011-02-10 21:48:58 UTC (rev 20270)
@@ -24,6 +24,7 @@
 #include "config.h"
 #include "gnc-entry-quickfill.h"
 #include "engine/gnc-event.h"
+#include "engine/gncEntry.h"
 
 /* This static indicates the debugging module that this .o belongs to. */
 static QofLogModule log_module = GNC_MOD_REGISTER;
@@ -156,12 +157,11 @@
 
     qfb = qof_book_get_data (book, key);
 
-    if (qfb)
+    if (!qfb)
     {
-        g_assert(use_invoices == qfb->using_invoices);
-        return qfb->qf;
+        qfb = build_shared_quickfill(book, key, use_invoices);
     }
 
-    qfb = build_shared_quickfill(book, key, use_invoices);
+    g_assert(use_invoices == qfb->using_invoices);
     return qfb->qf;
 }

Modified: gnucash/trunk/src/app-utils/gnc-entry-quickfill.h
===================================================================
--- gnucash/trunk/src/app-utils/gnc-entry-quickfill.h	2011-02-10 20:10:24 UTC (rev 20269)
+++ gnucash/trunk/src/app-utils/gnc-entry-quickfill.h	2011-02-10 21:48:58 UTC (rev 20270)
@@ -31,7 +31,6 @@
 #define GNC_ENTRY_QUICKFILL_H
 
 #include "qof.h"
-#include "engine/gncEntry.h"
 #include "app-utils/QuickFill.h"
 
 /** Create/fetch a quickfill GncEntry description strings.

Modified: gnucash/trunk/src/gnome-utils/dialog-transfer.c
===================================================================
--- gnucash/trunk/src/gnome-utils/dialog-transfer.c	2011-02-10 20:10:24 UTC (rev 20269)
+++ gnucash/trunk/src/gnome-utils/dialog-transfer.c	2011-02-10 21:48:58 UTC (rev 20270)
@@ -47,6 +47,7 @@
 #include "swig-runtime.h"
 #include "guile-mappings.h"
 #include "engine-helpers.h"
+#include "app-utils/QuickFill.h"
 
 
 #define DIALOG_TRANSFER_CM_CLASS "dialog-transfer"

Modified: gnucash/trunk/src/gnome-utils/dialog-transfer.h
===================================================================
--- gnucash/trunk/src/gnome-utils/dialog-transfer.h	2011-02-10 20:10:24 UTC (rev 20269)
+++ gnucash/trunk/src/gnome-utils/dialog-transfer.h	2011-02-10 21:48:58 UTC (rev 20270)
@@ -25,7 +25,6 @@
 #define DIALOG_TRANSFER_H
 
 #include "Account.h"
-#include "QuickFill.h"
 
 typedef struct _xferDialog XferDialog;
 



More information about the gnucash-changes mailing list