r20309 - gnucash/trunk/src/gnc-module - Fix const-correctness of gnc-module interface.
Christian Stimming
cstim at code.gnucash.org
Wed Feb 16 16:39:41 EST 2011
Author: cstim
Date: 2011-02-16 16:39:40 -0500 (Wed, 16 Feb 2011)
New Revision: 20309
Trac: http://svn.gnucash.org/trac/changeset/20309
Modified:
gnucash/trunk/src/gnc-module/gnc-module.c
gnucash/trunk/src/gnc-module/gnc-module.h
Log:
Fix const-correctness of gnc-module interface.
Modified: gnucash/trunk/src/gnc-module/gnc-module.c
===================================================================
--- gnucash/trunk/src/gnc-module/gnc-module.c 2011-02-16 21:08:26 UTC (rev 20308)
+++ gnucash/trunk/src/gnc-module/gnc-module.c 2011-02-16 21:39:40 UTC (rev 20309)
@@ -422,7 +422,7 @@
*************************************************************/
static GNCModule
-gnc_module_load_common(char * module_name, gint iface, gboolean optional)
+gnc_module_load_common(const char * module_name, gint iface, gboolean optional)
{
GNCLoadedModule * info;
@@ -532,13 +532,13 @@
GNCModule
-gnc_module_load(char * module_name, gint iface)
+gnc_module_load(const char * module_name, gint iface)
{
return gnc_module_load_common(module_name, iface, FALSE);
}
GNCModule
-gnc_module_load_optional(char * module_name, gint iface)
+gnc_module_load_optional(const char * module_name, gint iface)
{
return gnc_module_load_common(module_name, iface, TRUE);
}
Modified: gnucash/trunk/src/gnc-module/gnc-module.h
===================================================================
--- gnucash/trunk/src/gnc-module/gnc-module.h 2011-02-16 21:08:26 UTC (rev 20308)
+++ gnucash/trunk/src/gnc-module/gnc-module.h 2011-02-16 21:39:40 UTC (rev 20309)
@@ -21,14 +21,10 @@
/* load and unload a module. gnc_module_system_init() must be called
* before loading and unloading.
- *
- * Note/FIXME: There seems to be no real reason for why the argument
- * module_name is not a const gchar?! It certainly should be const
- * (because of passing string literals), and from a quick glance it is
- * also only used in a const way. */
+ */
/*@ dependent @*/
-GNCModule gnc_module_load(gchar * module_name, gint iface);
-GNCModule gnc_module_load_optional(gchar * module_name, gint iface);
+GNCModule gnc_module_load(const gchar * module_name, gint iface);
+GNCModule gnc_module_load_optional(const gchar * module_name, gint iface);
int gnc_module_unload(GNCModule mod);
#endif
More information about the gnucash-changes
mailing list