AUDIT: r20675 - gnucash/trunk/src/report/stylesheets - Bug #650757: Fix Easy & footer styles output wrong tags </btd> iso </b></td> preventing HTML 4.01 Transitional validation

Christian Stimming cstim at code.gnucash.org
Mon May 23 15:14:31 EDT 2011


Author: cstim
Date: 2011-05-23 15:14:31 -0400 (Mon, 23 May 2011)
New Revision: 20675
Trac: http://svn.gnucash.org/trac/changeset/20675

Modified:
   gnucash/trunk/src/report/stylesheets/stylesheet-easy.scm
   gnucash/trunk/src/report/stylesheets/stylesheet-footer.scm
Log:
Bug #650757: Fix Easy & footer styles output wrong tags </btd> iso </b></td> preventing HTML 4.01 Transitional validation

Patch by Bert:

This patch removes the wrong </btd> tags and closes the center tag in the
footer and easy stylesheets.

Just like Bug #650163 (and related to bug #616611) the easy & footer
stylesheets:
*output </btd> tags instead of <b></td>
*are missing a </center> tag

preventing html validation.

This patch removes the intended </b> and makes a clean </td> out of the
necessary tags. The styles are set through css anyhow. Furthmore it adds the
closing </center> tag.
BP

Modified: gnucash/trunk/src/report/stylesheets/stylesheet-easy.scm
===================================================================
--- gnucash/trunk/src/report/stylesheets/stylesheet-easy.scm	2011-05-23 19:14:20 UTC (rev 20674)
+++ gnucash/trunk/src/report/stylesheets/stylesheet-easy.scm	2011-05-23 19:14:31 UTC (rev 20675)
@@ -275,22 +275,22 @@
 
           (gnc:html-document-set-style!
              ssdoc "total-number-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "class" "total-number-cell"))
 
           (gnc:html-document-set-style!
              ssdoc "total-number-cell-neg"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "class" "total-number-cell neg"))
 
           (gnc:html-document-set-style!
              ssdoc "total-label-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "class" "total-label-cell"))
 
           (gnc:html-document-set-style!
              ssdoc "centered-label-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "class" "centered-label-cell"))
         )
         (begin ;; this is for gtkhtml
@@ -344,22 +344,22 @@
 
           (gnc:html-document-set-style!
              ssdoc "total-number-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "align" "right"))
 
           (gnc:html-document-set-style!
              ssdoc "total-number-cell-neg"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "align" "right"))
 
           (gnc:html-document-set-style!
              ssdoc "total-label-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "align" "left"))
 
           (gnc:html-document-set-style!
              ssdoc "centered-label-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "align" "center"))
         )
     )
@@ -471,6 +471,7 @@
        t 2 headcolumn
        (gnc:html-document-objects doc))
       (gnc:html-document-add-object! ssdoc t))
+    (gnc:html-document-add-object! ssdoc (gnc:make-html-text "</center>")) ;;TODO: make this a div instead of <center> (deprecated)
     ssdoc))
 
 (gnc:define-html-style-sheet 

Modified: gnucash/trunk/src/report/stylesheets/stylesheet-footer.scm
===================================================================
--- gnucash/trunk/src/report/stylesheets/stylesheet-footer.scm	2011-05-23 19:14:20 UTC (rev 20674)
+++ gnucash/trunk/src/report/stylesheets/stylesheet-footer.scm	2011-05-23 19:14:31 UTC (rev 20675)
@@ -289,22 +289,22 @@
 
           (gnc:html-document-set-style!
              ssdoc "total-number-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "class" "total-number-cell"))
 
           (gnc:html-document-set-style!
              ssdoc "total-number-cell-neg"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "class" "total-number-cell neg"))
 
           (gnc:html-document-set-style!
              ssdoc "total-label-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "class" "total-label-cell"))
 
           (gnc:html-document-set-style!
              ssdoc "centered-label-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "class" "centered-label-cell"))
         )
         (begin ;; this is for gtkhtml
@@ -358,22 +358,22 @@
 
           (gnc:html-document-set-style!
              ssdoc "total-number-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "align" "right"))
 
           (gnc:html-document-set-style!
              ssdoc "total-number-cell-neg"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "align" "right"))
 
           (gnc:html-document-set-style!
              ssdoc "total-label-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "align" "left"))
 
           (gnc:html-document-set-style!
              ssdoc "centered-label-cell"
-             'tag '("td" "b")
+             'tag '("td")
              'attribute (list "align" "center"))
         )
     )
@@ -489,6 +489,7 @@
        (gnc:html-table-set-cell!
        t 3 headcolumn
        (gnc:make-html-text footer-text)))
+    (gnc:html-document-add-object! ssdoc (gnc:make-html-text "</center>")) ;;TODO: make this a div instead of <center> (deprecated)
     ssdoc))
 
 (gnc:define-html-style-sheet 



More information about the gnucash-changes mailing list