r22313 - gnucash/trunk/src/gnome - Small optimizations to the previous commit.

Geert Janssens gjanssens at code.gnucash.org
Wed Aug 15 05:55:09 EDT 2012


Author: gjanssens
Date: 2012-08-15 05:55:09 -0400 (Wed, 15 Aug 2012)
New Revision: 22313
Trac: http://svn.gnucash.org/trac/changeset/22313

Modified:
   gnucash/trunk/src/gnome/reconcile-view.c
Log:
Small optimizations to the previous commit.

Modified: gnucash/trunk/src/gnome/reconcile-view.c
===================================================================
--- gnucash/trunk/src/gnome/reconcile-view.c	2012-08-15 09:54:59 UTC (rev 22312)
+++ gnucash/trunk/src/gnome/reconcile-view.c	2012-08-15 09:55:09 UTC (rev 22313)
@@ -474,10 +474,7 @@
             gtk_tree_model_get (model, &iter, 0, &entry, -1);
             gtk_tree_model_get (model, &iter, 5, &toggled, -1);
 
-            if(reconcile)
-                gtk_list_store_set (GTK_LIST_STORE (model), &iter, 5, 1, -1);
-            else
-                gtk_list_store_set (GTK_LIST_STORE (model), &iter, 5, 0, -1);
+            gtk_list_store_set (GTK_LIST_STORE (model), &iter, 5, reconcile, -1);
 
             if(reconcile != toggled)
                 gnc_reconcile_view_toggle (view, entry);
@@ -557,45 +554,11 @@
     case GDK_space:
         g_signal_stop_emission_by_name (widget, "key_press_event");
 
-        if (gnc_reconcile_view_num_selected (view) == 1)
-        {
+        toggle = gnc_reconcile_view_set_toggle (view);
+        gnc_reconcile_view_set_list (view, toggle);
+        return TRUE;
+        break;
 
-            entry = gnc_query_view_get_selected_entry (qview);
-
-            model = gtk_tree_view_get_model (GTK_TREE_VIEW (qview));
-            valid = gtk_tree_model_get_iter_first (model, &iter);
-
-            while (valid)
-            {
-                /* Walk through the list, reading each row, column 0
-                   has a pointer to the required entry */
-                gtk_tree_model_get (model, &iter, 0, &pointer, -1);
-
-                if(pointer == entry)
-                {
-                    /* Column 5 is the toggle column */
-                    gtk_tree_model_get (model, &iter, 5, &toggle, -1);
-
-                    if(toggle)
-                        gtk_list_store_set (GTK_LIST_STORE (model), &iter, 5, 0, -1);
-                    else
-                        gtk_list_store_set (GTK_LIST_STORE (model), &iter, 5, 1, -1);
-                }
-                valid = gtk_tree_model_iter_next (model, &iter);
-            }
-            gnc_reconcile_view_toggle (view, entry);
-
-            return TRUE;
-            break;
-        }
-        else
-        {
-            toggle = gnc_reconcile_view_set_toggle (view);
-            gnc_reconcile_view_set_list (view, toggle);
-            return TRUE;
-            break;
-        }
-
     default:
         return FALSE;
     }



More information about the gnucash-changes mailing list