r22544 - gnucash/trunk/src/html - Fix potential crash with malformed reports

[Geert Janssens]

Author: gjanssens
Date: 2012-11-13 07:32:09 -0500 (Tue, 13 Nov 2012)
New Revision: 22544
Trac: http://svn.gnucash.org/trac/changeset/22544

Modified:
   gnucash/trunk/src/html/gnc-html-webkit.c
Log:
Fix potential crash with malformed reports

If reports contain an opening <object> tag, but omit the closing tag,
the html string is freed and still used some time later.

Modified: gnucash/trunk/src/html/gnc-html-webkit.c
===================================================================
--- gnucash/trunk/src/html/gnc-html-webkit.c	2012-11-12 22:11:27 UTC (rev 22543)
+++ gnucash/trunk/src/html/gnc-html-webkit.c	2012-11-13 12:32:09 UTC (rev 22544)
@@ -383,7 +383,7 @@
                 Return the original html string because we can't properly parse it */
             g_free (classid_str);
             g_free (html_str_result);
-            return html_str;
+            return g_strdup (html_str);
         }
         end_object_tag += strlen( "</object>" );
         object_contents = g_strndup( object_tag, (end_object_tag - object_tag) );