r22930 - gnucash/branches/2.4/src/import-export - [22929] Finally fix the maddening long waiting times after clicking "Ok" in the import matcher window.

Christian Stimming cstim at code.gnucash.org
Wed Apr 24 05:10:29 EDT 2013


Author: cstim
Date: 2013-04-24 05:10:29 -0400 (Wed, 24 Apr 2013)
New Revision: 22930
Trac: http://svn.gnucash.org/trac/changeset/22930

Modified:
   gnucash/branches/2.4/src/import-export/import-main-matcher.c
Log:
[22929] Finally fix the maddening long waiting times after clicking "Ok" in the import matcher window.

Turns out we were simply missing a suspend_gui_refresh call before actually
processing the results. Sigh.

(Can go into 2.4 because the bugfix is so surprisingly simple.)

Modified: gnucash/branches/2.4/src/import-export/import-main-matcher.c
===================================================================
--- gnucash/branches/2.4/src/import-export/import-main-matcher.c	2013-04-24 09:08:31 UTC (rev 22929)
+++ gnucash/branches/2.4/src/import-export/import-main-matcher.c	2013-04-24 09:10:29 UTC (rev 22930)
@@ -41,6 +41,7 @@
 #include "import-match-picker.h"
 #include "import-backend.h"
 #include "import-account-matcher.h"
+#include "app-utils/gnc-component-manager.h"
 
 #define GCONF_SECTION "dialogs/import/generic_matcher/transaction_list"
 
@@ -145,6 +146,10 @@
     if (!gtk_tree_model_get_iter_first(model, &iter))
         return;
 
+    /* Don't run any queries and/or split sorts while processing the matcher
+    results. */
+    gnc_suspend_gui_refresh();
+
     do
     {
         gtk_tree_model_get(model, &iter,
@@ -192,6 +197,9 @@
     }
     g_slist_free(refs_list);
 
+    /* Allow GUI refresh again. */
+    gnc_resume_gui_refresh();
+
     gnc_gen_trans_list_delete (info);
     /* DEBUG ("End") */
 }



More information about the gnucash-changes mailing list