r23478 - gnucash/trunk/src/core-utils - Bug 719726 - Click on File -> Open seg-faults

John Ralls jralls at code.gnucash.org
Mon Dec 2 18:46:49 EST 2013


Author: jralls
Date: 2013-12-02 18:46:49 -0500 (Mon, 02 Dec 2013)
New Revision: 23478
Trac: http://svn.gnucash.org/trac/changeset/23478

Modified:
   gnucash/trunk/src/core-utils/gnc-uri-utils.c
Log:
Bug 719726 - Click on File -> Open seg-faults

in gnc_uri_get_components in gnucash gnc-uri-utils.c:137

g_strsplit doesn't return a 2-element array if presented with an
empty string.

Modified: gnucash/trunk/src/core-utils/gnc-uri-utils.c
===================================================================
--- gnucash/trunk/src/core-utils/gnc-uri-utils.c	2013-12-02 23:46:40 UTC (rev 23477)
+++ gnucash/trunk/src/core-utils/gnc-uri-utils.c	2013-12-02 23:46:49 UTC (rev 23478)
@@ -98,7 +98,7 @@
     *password = NULL;
     *path     = NULL;
 
-    g_return_if_fail( uri != NULL );
+    g_return_if_fail( uri != NULL && strlen (uri) > 0);
 
     splituri = g_strsplit ( uri, "://", 2 );
     if ( splituri[1] == NULL )



More information about the gnucash-changes mailing list