r23446 - gnucash/branches/2.4/src - [22070] Fix memory leak: Missing regfree() after regcomp().
Geert Janssens
gjanssens at code.gnucash.org
Tue Nov 26 11:55:56 EST 2013
Author: gjanssens
Date: 2013-11-26 11:55:55 -0500 (Tue, 26 Nov 2013)
New Revision: 23446
Trac: http://svn.gnucash.org/trac/changeset/23446
Modified:
gnucash/branches/2.4/src/backend/xml/gnc-backend-xml.c
gnucash/branches/2.4/src/html/gnc-html.c
Log:
[22070] Fix memory leak: Missing regfree() after regcomp().
This fix is backported because it solves this bug:
Bug 681907 - Save operation is leaking seriously, eventually GnuCash uses 6.4 GB RAM
Modified: gnucash/branches/2.4/src/backend/xml/gnc-backend-xml.c
===================================================================
--- gnucash/branches/2.4/src/backend/xml/gnc-backend-xml.c 2013-11-26 13:53:33 UTC (rev 23445)
+++ gnucash/branches/2.4/src/backend/xml/gnc-backend-xml.c 2013-11-26 16:55:55 UTC (rev 23446)
@@ -879,6 +879,7 @@
else if (regexec(&pattern, stamp_start, 0, NULL, 0) == 0)
got_date_stamp = TRUE;
+ regfree(&pattern);
g_free(expression);
if (!got_date_stamp) /* Not a gnucash created file after all... */
Modified: gnucash/branches/2.4/src/html/gnc-html.c
===================================================================
--- gnucash/branches/2.4/src/html/gnc-html.c 2013-11-26 13:53:33 UTC (rev 23445)
+++ gnucash/branches/2.4/src/html/gnc-html.c 2013-11-26 16:55:55 UTC (rev 23446)
@@ -179,6 +179,7 @@
machine = g_strndup( path + match[1].rm_so, match[1].rm_eo - match[1].rm_so );
}
}
+ regfree(&compiled_m);
return machine;
}
More information about the gnucash-changes
mailing list