r23336 - gnucash/trunk/src/engine - Add off-by-one warning in comment
Geert Janssens
gjanssens at code.gnucash.org
Sat Oct 26 04:40:14 EDT 2013
Author: gjanssens
Date: 2013-10-26 04:40:06 -0400 (Sat, 26 Oct 2013)
New Revision: 23336
Trac: http://svn.gnucash.org/trac/changeset/23336
Modified:
gnucash/trunk/src/engine/gnc-budget.c
Log:
Add off-by-one warning in comment
Taken from https://bugzilla.gnome.org/show_bug.cgi?id=709329#c7
Modified: gnucash/trunk/src/engine/gnc-budget.c
===================================================================
--- gnucash/trunk/src/engine/gnc-budget.c 2013-10-26 08:38:44 UTC (rev 23335)
+++ gnucash/trunk/src/engine/gnc-budget.c 2013-10-26 08:40:06 UTC (rev 23336)
@@ -507,6 +507,8 @@
gchar path[BUF_SIZE];
gchar *bufend;
+ /* Watch out for an off-by-one error here:
+ * period_num starts from 0 while num_periods starts from 1 */
if (period_num >= GET_PRIVATE(budget)->num_periods) {
PWARN("Period %i does not exist", period_num);
return;
More information about the gnucash-changes
mailing list