r23352 - gnucash/trunk/src/gnome-utils - Remove function that no longer adds value

[Geert Janssens]

Author: gjanssens
Date: 2013-10-29 15:26:39 -0400 (Tue, 29 Oct 2013)
New Revision: 23352
Trac: http://svn.gnucash.org/trac/changeset/23352

Modified:
   gnucash/trunk/src/gnome-utils/gnc-tree-view-account.c
   gnucash/trunk/src/gnome-utils/gnc-tree-view-commodity.c
   gnucash/trunk/src/gnome-utils/gnc-tree-view-owner.c
   gnucash/trunk/src/gnome-utils/gnc-tree-view-price.c
   gnucash/trunk/src/gnome-utils/gnc-tree-view-split-reg.c
   gnucash/trunk/src/gnome-utils/gnc-tree-view-sx-list.c
   gnucash/trunk/src/gnome-utils/gnc-tree-view.c
   gnucash/trunk/src/gnome-utils/gnc-tree-view.h
Log:
Remove function that no longer adds value

Modified: gnucash/trunk/src/gnome-utils/gnc-tree-view-account.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-tree-view-account.c	2013-10-29 19:26:23 UTC (rev 23351)
+++ gnucash/trunk/src/gnome-utils/gnc-tree-view-account.c	2013-10-29 19:26:39 UTC (rev 23352)
@@ -705,7 +705,7 @@
     /* Set up the view private sort layer on the common model. */
     s_model = gtk_tree_model_sort_new_with_model(f_model);
     g_object_unref(G_OBJECT(f_model));
-    gnc_tree_view_set_model (view, s_model);
+    gtk_tree_view_set_model (GTK_TREE_VIEW (view), s_model);
     g_object_unref(G_OBJECT(s_model));
 
     /* Set default visibilities */

Modified: gnucash/trunk/src/gnome-utils/gnc-tree-view-commodity.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-tree-view-commodity.c	2013-10-29 19:26:23 UTC (rev 23351)
+++ gnucash/trunk/src/gnome-utils/gnc-tree-view-commodity.c	2013-10-29 19:26:39 UTC (rev 23352)
@@ -371,7 +371,7 @@
     /* Create our view */
     view = g_object_new (GNC_TYPE_TREE_VIEW_COMMODITY,
                          "name", "commodity_tree", NULL);
-    gnc_tree_view_set_model (view, s_model);
+    gtk_tree_view_set_model (GTK_TREE_VIEW (view), s_model);
     g_object_unref(G_OBJECT(s_model));
 
     DEBUG("model ref count is %d",   G_OBJECT(model)->ref_count);

Modified: gnucash/trunk/src/gnome-utils/gnc-tree-view-owner.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-tree-view-owner.c	2013-10-29 19:26:23 UTC (rev 23351)
+++ gnucash/trunk/src/gnome-utils/gnc-tree-view-owner.c	2013-10-29 19:26:39 UTC (rev 23352)
@@ -385,7 +385,7 @@
     /* Set up the view private sort layer on the common model. */
     s_model = gtk_tree_model_sort_new_with_model(f_model);
     g_object_unref(G_OBJECT(f_model));
-    gnc_tree_view_set_model (view, s_model);
+    gtk_tree_view_set_model (GTK_TREE_VIEW (view), s_model);
     g_object_unref(G_OBJECT(s_model));
 
     /* Set default visibilities */

Modified: gnucash/trunk/src/gnome-utils/gnc-tree-view-price.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-tree-view-price.c	2013-10-29 19:26:23 UTC (rev 23351)
+++ gnucash/trunk/src/gnome-utils/gnc-tree-view-price.c	2013-10-29 19:26:39 UTC (rev 23352)
@@ -412,7 +412,7 @@
     /* Create our view */
     view = g_object_new (GNC_TYPE_TREE_VIEW_PRICE,
                          "name", "price_tree", NULL);
-    gnc_tree_view_set_model (view, s_model);
+    gtk_tree_view_set_model (GTK_TREE_VIEW (view), s_model);
     g_object_unref(G_OBJECT(s_model));
 
     DEBUG("model ref count is %d",   G_OBJECT(model)->ref_count);

Modified: gnucash/trunk/src/gnome-utils/gnc-tree-view-split-reg.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-tree-view-split-reg.c	2013-10-29 19:26:23 UTC (rev 23351)
+++ gnucash/trunk/src/gnome-utils/gnc-tree-view-split-reg.c	2013-10-29 19:26:39 UTC (rev 23352)
@@ -1076,7 +1076,7 @@
     PINFO("#### Before View connected to Model ####");
 
     // Connect model to tree view
-    gnc_tree_view_set_model (GNC_TREE_VIEW (view), s_model);
+    gtk_tree_view_set_model (GTK_TREE_VIEW (view), s_model);
     g_object_unref (G_OBJECT (s_model));
 
     PINFO("#### After View connected to Model ####");

Modified: gnucash/trunk/src/gnome-utils/gnc-tree-view-sx-list.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-tree-view-sx-list.c	2013-10-29 19:26:23 UTC (rev 23351)
+++ gnucash/trunk/src/gnome-utils/gnc-tree-view-sx-list.c	2013-10-29 19:26:39 UTC (rev 23352)
@@ -158,7 +158,7 @@
     priv = GNC_TREE_VIEW_SX_LIST_GET_PRIVATE(view);
 
     priv->tree_model = GTK_TREE_MODEL(gnc_sx_list_tree_model_adapter_new(sx_instances));
-    gnc_tree_view_set_model(view, GTK_TREE_MODEL(priv->tree_model));
+    gtk_tree_view_set_model (GTK_TREE_VIEW (view), GTK_TREE_MODEL(priv->tree_model));
 
     col = gnc_tree_view_add_text_column(view, _("Name"), "name", NULL,
                                         "Semi-Monthly Paycheck",

Modified: gnucash/trunk/src/gnome-utils/gnc-tree-view.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-tree-view.c	2013-10-29 19:26:23 UTC (rev 23351)
+++ gnucash/trunk/src/gnome-utils/gnc-tree-view.c	2013-10-29 19:26:39 UTC (rev 23352)
@@ -1497,27 +1497,6 @@
 /*                    Tree View Creation                    */
 /************************************************************/
 
-/** Attach a data model to a visible GncTreeView widget.  Users of
- *  this view object must use this function instead of directly
- *  calling the gtk_tree_view_set_model function.
- *
- *  FIXME Investigate if it still makes sense once saving/restoring
- *        state is reimplemented.
- *
- *  Parameters are defined in gnc-tree-view.h
- */
-void
-gnc_tree_view_set_model(GncTreeView *view, GtkTreeModel *model)
-{
-    GncTreeViewPrivate *priv;
-    GtkTreeModel *old_model;
-
-    /* Remove existing callback */
-    priv = GNC_TREE_VIEW_GET_PRIVATE(view);
-
-    gtk_tree_view_set_model (GTK_TREE_VIEW(view), model);
-}
-
 static gint
 gnc_tree_view_count_visible_columns(GncTreeView *view)
 {

Modified: gnucash/trunk/src/gnome-utils/gnc-tree-view.h
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-tree-view.h	2013-10-29 19:26:23 UTC (rev 23351)
+++ gnucash/trunk/src/gnome-utils/gnc-tree-view.h	2013-10-29 19:26:39 UTC (rev 23352)
@@ -303,18 +303,6 @@
 /** @name Tree View Properties */
 /** @{ */
 
-/** Attach a data model to a visible GncTreeView widget.  Users of
- *  this view object must use this function instead of directly
- *  calling the gtk_tree_view_set_model function.  This function takes
- *  the additional step of attaching a callback function to the model
- *  to catch any changes to the sorting of the model.
- *
- *  @param view The visible tree widget.
- *
- *  @param model The data model to attach.
- */
-void gnc_tree_view_set_model(GncTreeView *view, GtkTreeModel *model);
-
 /** Make all the correct columns visible, respecting their default
  *  visibility setting, their "always" visibility setting, and the
  *  last saved state if available.