gnucash maint: Revert "Bug 740471 - Applying payment to invoice Segmentation fault"

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/ad09bcfd (commit)
	from  https://github.com/Gnucash/gnucash/commit/d5ade4cb (commit)



commit ad09bcfd4a3c32288b1ad28dccb2bf31683a5be0
Author: Geert Janssens <janssens-geert at telenet.be>
Date:   Mon Dec 29 16:30:04 2014 +0100

    Revert "Bug 740471 -  Applying payment to invoice Segmentation fault"
    
    This reverts commit a6d7184d830d8a8bc0c339d012ac17c249a40994.
    The patch had no effect on the bug at all and needlessly clutters the code.

diff --git a/src/engine/gncOwner.c b/src/engine/gncOwner.c
index 70f41db..25fa682 100644
--- a/src/engine/gncOwner.c
+++ b/src/engine/gncOwner.c
@@ -1232,11 +1232,12 @@ void gncOwnerAutoApplyPaymentsWithLots (const GncOwner *owner, GList *lots)
          * Note that due to the iterative nature of this function lots
          * in the list may become empty/closed before they are evaluated as
          * base lot, so we should check this for each lot. */
-        if (!left_lot || qof_instance_get_destroying (left_lot))
+        if (!left_lot)
             continue;
         if (gnc_lot_count_splits (left_lot) == 0)
         {
             gnc_lot_destroy (left_lot);
+            left_iter->data = NULL;
             continue;
         }
         if (gnc_lot_is_closed (left_lot))
@@ -1262,11 +1263,12 @@ void gncOwnerAutoApplyPaymentsWithLots (const GncOwner *owner, GList *lots)
              * Note that due to the iterative nature of this function lots
              * in the list may become empty/closed before they are evaluated as
              * base lot, so we should check this for each lot. */
-            if (!right_lot || qof_instance_get_destroying (right_lot))
+            if (!right_lot)
                 continue;
             if (gnc_lot_count_splits (right_lot) == 0)
             {
                 gnc_lot_destroy (right_lot);
+                right_iter->data = NULL;
                 continue;
             }
             if (gnc_lot_is_closed (right_lot))



Summary of changes:
 src/engine/gncOwner.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)