r23705 - gnucash/trunk/src - Bug 605991 Help button on New and Edit Job dialogs brings up wrong help page. With this patch I linked almost all business features to corresponding help pages. For features not yet documented, the button will open the initial chapter of the business section.

Cristian Marchi cmarchi at code.gnucash.org
Sat Jan 18 13:47:52 EST 2014


Author: cmarchi
Date: 2014-01-18 13:47:52 -0500 (Sat, 18 Jan 2014)
New Revision: 23705
Trac: http://svn.gnucash.org/trac/changeset/23705

Modified:
   gnucash/trunk/src/business/business-gnome/dialog-customer.c
   gnucash/trunk/src/business/business-gnome/dialog-employee.c
   gnucash/trunk/src/business/business-gnome/dialog-invoice.c
   gnucash/trunk/src/business/business-gnome/dialog-job.c
   gnucash/trunk/src/business/business-gnome/dialog-order.c
   gnucash/trunk/src/business/business-gnome/dialog-vendor.c
   gnucash/trunk/src/gnome-utils/gnc-ui.h
   gnucash/trunk/src/plugins/bi_import/dialog-bi-import-gui.c
   gnucash/trunk/src/plugins/customer_import/dialog-customer-import-gui.c
Log:
Bug 605991 Help button on New and Edit Job dialogs brings up wrong help page. With this patch I linked almost all business features to corresponding help pages. For features not yet documented, the button will open the initial chapter of the business section.

Modified: gnucash/trunk/src/business/business-gnome/dialog-customer.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-customer.c	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/business/business-gnome/dialog-customer.c	2014-01-18 18:47:52 UTC (rev 23705)
@@ -390,7 +390,7 @@
 void
 gnc_customer_window_help_cb (GtkWidget *widget, gpointer data)
 {
-    gnc_gnome_help(HF_HELP, HL_USAGE);
+    gnc_gnome_help(HF_HELP, HL_USAGE_CUSTOMER);
 }
 
 void

Modified: gnucash/trunk/src/business/business-gnome/dialog-employee.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-employee.c	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/business/business-gnome/dialog-employee.c	2014-01-18 18:47:52 UTC (rev 23705)
@@ -274,7 +274,7 @@
 void
 gnc_employee_window_help_cb (GtkWidget *widget, gpointer data)
 {
-    gnc_gnome_help(HF_HELP, HL_USAGE);
+    gnc_gnome_help(HF_HELP, HL_USAGE_BSNSS);
 }
 
 void

Modified: gnucash/trunk/src/business/business-gnome/dialog-invoice.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-invoice.c	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/business/business-gnome/dialog-invoice.c	2014-01-18 18:47:52 UTC (rev 23705)
@@ -454,7 +454,7 @@
 void
 gnc_invoice_window_help_cb (GtkWidget *widget, gpointer data)
 {
-    gnc_gnome_help(HF_HELP, HL_USAGE);
+    gnc_gnome_help(HF_HELP, HL_USAGE_INVOICE);
 }
 
 void

Modified: gnucash/trunk/src/business/business-gnome/dialog-job.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-job.c	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/business/business-gnome/dialog-job.c	2014-01-18 18:47:52 UTC (rev 23705)
@@ -198,7 +198,7 @@
 void
 gnc_job_window_help_cb (GtkWidget *widget, gpointer data)
 {
-    gnc_gnome_help(HF_HELP, HL_USAGE);
+    gnc_gnome_help(HF_HELP, HL_USAGE_BSNSS);
 }
 
 

Modified: gnucash/trunk/src/business/business-gnome/dialog-order.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-order.c	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/business/business-gnome/dialog-order.c	2014-01-18 18:47:52 UTC (rev 23705)
@@ -232,7 +232,7 @@
 void
 gnc_order_window_help_cb (GtkWidget *widget, gpointer data)
 {
-    gnc_gnome_help(HF_HELP, HL_USAGE);
+    gnc_gnome_help(HF_HELP, HL_USAGE_BILL);
 }
 
 void

Modified: gnucash/trunk/src/business/business-gnome/dialog-vendor.c
===================================================================
--- gnucash/trunk/src/business/business-gnome/dialog-vendor.c	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/business/business-gnome/dialog-vendor.c	2014-01-18 18:47:52 UTC (rev 23705)
@@ -261,7 +261,7 @@
 void
 gnc_vendor_window_help_cb (GtkWidget *widget, gpointer data)
 {
-    gnc_gnome_help(HF_HELP, HL_USAGE);
+    gnc_gnome_help(HF_HELP, HL_USAGE_VENDOR);
 }
 
 void

Modified: gnucash/trunk/src/gnome-utils/gnc-ui.h
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-ui.h	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/gnome-utils/gnc-ui.h	2014-01-18 18:47:52 UTC (rev 23705)
@@ -52,6 +52,11 @@
 
 /** Links in the Help Files *****************************************/
 #define HL_USAGE             "usage"
+#define HL_USAGE_BSNSS       "chapter_busnss"
+#define HL_USAGE_INVOICE     "busnss-ar-invoices1"
+#define HL_USAGE_BILL        "busnss-ap-bills1"
+#define HL_USAGE_CUSTOMER    "busnss-ar-customers1"
+#define HL_USAGE_VENDOR      "busnss-ap-vendors1"
 #define HL_ACC               "acct-create"
 #define HL_ACCEDIT           "acct-edit"
 #define HL_COMMODITY         "tool-commodity"

Modified: gnucash/trunk/src/plugins/bi_import/dialog-bi-import-gui.c
===================================================================
--- gnucash/trunk/src/plugins/bi_import/dialog-bi-import-gui.c	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/plugins/bi_import/dialog-bi-import-gui.c	2014-01-18 18:47:52 UTC (rev 23705)
@@ -235,7 +235,7 @@
 void
 gnc_bi_import_gui_help_cb (GtkWidget *widget, gpointer data)
 {
-    gnc_gnome_help(HF_HELP, HL_USAGE);
+    gnc_gnome_help(HF_HELP, HL_USAGE_BSNSS);
 }
 
 static void

Modified: gnucash/trunk/src/plugins/customer_import/dialog-customer-import-gui.c
===================================================================
--- gnucash/trunk/src/plugins/customer_import/dialog-customer-import-gui.c	2014-01-18 16:56:12 UTC (rev 23704)
+++ gnucash/trunk/src/plugins/customer_import/dialog-customer-import-gui.c	2014-01-18 18:47:52 UTC (rev 23705)
@@ -221,7 +221,7 @@
 void
 gnc_customer_import_gui_help_cb (GtkWidget *widget, gpointer data)
 {
-    gnc_gnome_help(HF_HELP, HL_USAGE);
+    gnc_gnome_help(HF_HELP, HL_USAGE_BSNSS);
 }
 
 static void



More information about the gnucash-changes mailing list