gnucash maint: Bug 746155 - Reports: html-acct-table prepend-row! & prepend-col! unknown variables

Geert Janssens gjanssens at code.gnucash.org
Fri Dec 18 12:12:20 EST 2015


Updated	 via  https://github.com/Gnucash/gnucash/commit/9d076500 (commit)
	from  https://github.com/Gnucash/gnucash/commit/2f2d1d91 (commit)



commit 9d076500771f1cc8edb3f19b3b76ce8a9e4d39cd
Author: Geert Janssens <janssens-geert at telenet.be>
Date:   Fri Dec 18 18:12:03 2015 +0100

    Bug 746155 - Reports: html-acct-table prepend-row! & prepend-col! unknown variables
    
    Fixed following the suggestions by Tony Kerns.
    In addition the function names have been made more consistent -
    they all end with a ! now as they change data.
    
    Note these functions aren't used anywhere in the gnucash
    code, but may affect custom reports by some users.

diff --git a/src/report/report-system/html-acct-table.scm b/src/report/report-system/html-acct-table.scm
index ce509eb..e489524 100644
--- a/src/report/report-system/html-acct-table.scm
+++ b/src/report/report-system/html-acct-table.scm
@@ -1018,33 +1018,33 @@
 (define (gnc:html-acct-table-set-row-env! acct-table row env)
   (gnc:html-acct-table-set-cell! acct-table row -1 env))
 
-(define (gnc:html-acct-table-append-row acct-table objects)
+(define (gnc:html-acct-table-append-row! acct-table newrow)
   (gnc:html-table-append-row!
    (gnc:_html-acct-table-matrix_ acct-table)
    (map
     (lambda (x) (gnc:make-html-table-cell (list x)))
-    objects)))
+    newrow)))
 
 (define (gnc:html-acct-table-prepend-row! acct-table newrow)
   (gnc:html-table-prepend-row!
    (gnc:_html-acct-table-matrix_ acct-table)
    (map
     (lambda (x) (gnc:make-html-table-cell (list x)))
-    objects)))
+    newrow)))
 
-(define (gnc:html-acct-table-append-col acct-table objects)
+(define (gnc:html-acct-table-append-col! acct-table newcol)
   (gnc:html-table-append-col!
    (gnc:_html-acct-table-matrix_ acct-table)
    (map
     (lambda (x) (gnc:make-html-table-cell (list x)))
-    objects)))
+    newcol)))
 
 (define (gnc:html-acct-table-prepend-col! acct-table newrow)
   (gnc:html-table-prepend-col!
    (gnc:_html-acct-table-matrix_ acct-table)
    (map
     (lambda (x) (gnc:make-html-table-cell (list x)))
-    objects)))
+    newcol)))
 
 (define (gnc:html-acct-table-remove-last-row! acct-table)
   (gnc:html-table-remove-last-row! (gnc:_html-acct-table-matrix_ acct-table)))
diff --git a/src/report/report-system/report-system.scm b/src/report/report-system/report-system.scm
index 3dde3c6..0efdd9d 100644
--- a/src/report/report-system/report-system.scm
+++ b/src/report/report-system/report-system.scm
@@ -530,9 +530,9 @@
 (export gnc:html-acct-table-set-cell!)
 (export gnc:html-acct-table-get-row-env)
 (export gnc:html-acct-table-set-row-env!)
-(export gnc:html-acct-table-append-row)
+(export gnc:html-acct-table-append-row!)
 (export gnc:html-acct-table-prepend-row!)
-(export gnc:html-acct-table-append-col)
+(export gnc:html-acct-table-append-col!)
 (export gnc:html-acct-table-prepend-col!)
 (export gnc:html-acct-table-remove-last-row!)
 (export gnc:html-acct-table-render)



Summary of changes:
 src/report/report-system/html-acct-table.scm | 12 ++++++------
 src/report/report-system/report-system.scm   |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)



More information about the gnucash-changes mailing list