gnucash maint: Bug 727647 - "gncInvoiceGetTotal" is not read-only function?

Geert Janssens gjanssens at code.gnucash.org
Wed Jan 28 10:06:50 EST 2015


Updated	 via  https://github.com/Gnucash/gnucash/commit/0ff9eba9 (commit)
	from  https://github.com/Gnucash/gnucash/commit/5e60a234 (commit)



commit 0ff9eba94f0d273ec11e4e19da42019bdc6cc802
Author: Geert Janssens <janssens-geert at telenet.be>
Date:   Wed Jan 28 17:00:21 2015 +0100

    Bug 727647 - "gncInvoiceGetTotal" is not read-only function?
    
    The root cause is in gncRecomputeValues. This function
    only alters runtime cached values so it should not
    trigger a book dirty action (mark_entry).

diff --git a/src/engine/gncEntry.c b/src/engine/gncEntry.c
index f4c1786..7245829 100644
--- a/src/engine/gncEntry.c
+++ b/src/engine/gncEntry.c
@@ -1327,7 +1327,6 @@ gncEntryRecomputeValues (GncEntry *entry)
     /* Determine the commodity denominator */
     denom = get_entry_commodity_denom (entry);
 
-    gncEntryBeginEdit (entry);
     /* Compute the invoice values */
     gncEntryComputeValue (entry->quantity, entry->i_price,
                           (entry->i_taxable ? entry->i_tax_table : NULL),
@@ -1360,8 +1359,6 @@ gncEntryRecomputeValues (GncEntry *entry)
     entry->b_tax_value_rounded = gnc_numeric_convert (entry->b_tax_value, denom,
                                  GNC_HOW_RND_ROUND_HALF_UP);
     entry->values_dirty = FALSE;
-    mark_entry (entry);
-    gncEntryCommitEdit (entry);
 }
 
 /* The "Int" functions below are for internal use only.



Summary of changes:
 src/engine/gncEntry.c | 3 ---
 1 file changed, 3 deletions(-)



More information about the gnucash-changes mailing list