gnucash maint: Bug 766028 - crash on manual addition of price entry in Price Editor

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/f679bf70 (commit)
	from  https://github.com/Gnucash/gnucash/commit/eaa68cff (commit)



commit f679bf70e8293021c4d42bdd331d0184d0ed140e
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue May 10 13:28:58 2016 -0700

    Bug 766028 - crash on manual addition of price entry in Price Editor
    
    gnc_pricedb_remove_price invalidates db->commodity_hash so removing the
    old price needs to be done before it's retrieved.

diff --git a/src/engine/gnc-pricedb.c b/src/engine/gnc-pricedb.c
index 790cf32..f777f5f 100644
--- a/src/engine/gnc-pricedb.c
+++ b/src/engine/gnc-pricedb.c
@@ -1047,6 +1047,22 @@ add_price(GNCPriceDB *db, GNCPrice *p)
         LEAVE ("no commodity hash found ");
         return FALSE;
     }
+/* Check for an existing price on the same day. If there is no existing price,
+ * add this one. If this price is of equal or better precedence than the old
+ * one, copy this one over the old one.
+ */
+    old_price = gnc_pricedb_lookup_day (db, p->commodity, p->currency,
+                                        p->tmspec);
+    if (!db->bulk_update && old_price != NULL)
+    {
+        if (p->source > old_price->source)
+        {
+            gnc_price_unref(p);
+            LEAVE ("Better price already in DB.");
+            return FALSE;
+        }
+        gnc_pricedb_remove_price(db, old_price);
+    }
 
     currency_hash = g_hash_table_lookup(db->commodity_hash, commodity);
     if (!currency_hash)
@@ -1068,22 +1084,6 @@ add_price(GNCPriceDB *db, GNCPrice *p)
         return FALSE;
     }
 
-/* Check for an existing price on the same day. If there is no existing price,
- * add this one. If this price is of equal or better precedence than the old
- * one, copy this one over the old one.
- */
-    old_price = gnc_pricedb_lookup_day (db, p->commodity, p->currency,
-                                        p->tmspec);
-    if (!db->bulk_update && old_price != NULL)
-    {
-        if (p->source > old_price->source)
-        {
-            gnc_price_unref(p);
-            LEAVE ("Better price already in DB.");
-            return FALSE;
-        }
-        gnc_pricedb_remove_price(db, old_price);
-    }
     g_hash_table_insert(currency_hash, currency, price_list);
     p->db = db;
 



Summary of changes:
 src/engine/gnc-pricedb.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)