gnucash maint: Bug 782897 - Stock Split Assistant crashes GnuCash if you enter a New...

John Ralls jralls at code.gnucash.org
Sat Jun 24 21:07:05 EDT 2017


Updated	 via  https://github.com/Gnucash/gnucash/commit/99a732cb (commit)
	from  https://github.com/Gnucash/gnucash/commit/c80dad74 (commit)



commit 99a732cb6ae619473acc048229534f560f9160b5
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Jun 24 18:06:42 2017 -0700

    Bug 782897 - Stock Split Assistant crashes GnuCash if you enter a New...
    
    Price and that already exists in the Price DB
    
    Should have crashed regardless: The pricedb takes ownership of the
    price object and unreffing it is going to cause trouble eventually.
    
    tock Split Assistant crashes GnuCash if you enter a New Price and that
    already exists in the Price DB

diff --git a/src/gnome/assistant-stock-split.c b/src/gnome/assistant-stock-split.c
index 262df75..a2d5ba9 100644
--- a/src/gnome/assistant-stock-split.c
+++ b/src/gnome/assistant-stock-split.c
@@ -409,7 +409,6 @@ gnc_stock_split_assistant_finish (GtkAssistant *assistant,
         if (!gnc_pricedb_add_price (pdb, price))
             gnc_error_dialog (info->window, "%s", _("Error adding price."));
 
-        gnc_price_unref (price);
     }
 
     amount = gnc_amount_edit_get_amount (GNC_AMOUNT_EDIT (info->cash_edit));



Summary of changes:
 src/gnome/assistant-stock-split.c | 1 -
 1 file changed, 1 deletion(-)



More information about the gnucash-changes mailing list