gnucash maint: Ensure all C++ class member raw pointers are default-initialized to nullptr.

John Ralls jralls at code.gnucash.org
Fri Aug 10 15:24:51 EDT 2018


Updated	 via  https://github.com/Gnucash/gnucash/commit/2f861bc2 (commit)
	from  https://github.com/Gnucash/gnucash/commit/1e87d069 (commit)



commit 2f861bc2a49d77cecce056cbc605a74d0b963f5a
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Aug 10 12:21:28 2018 -0700

    Ensure all C++ class member raw pointers are default-initialized to nullptr.

diff --git a/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp b/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp
index 336d2c4..0c7e854 100644
--- a/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp
+++ b/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp
@@ -53,7 +53,7 @@ public:
     void add_where_cond(QofIdTypeConst, const PairVec&) override;
 
 private:
-    const GncSqlConnection* m_conn;
+    const GncSqlConnection* m_conn = nullptr;
     std::string m_sql;
 };
 
diff --git a/libgnucash/backend/dbi/gnc-dbisqlconnection.hpp b/libgnucash/backend/dbi/gnc-dbisqlconnection.hpp
index 56766e1..bb71a96 100644
--- a/libgnucash/backend/dbi/gnc-dbisqlconnection.hpp
+++ b/libgnucash/backend/dbi/gnc-dbisqlconnection.hpp
@@ -86,7 +86,7 @@ public:
                                 const ColVec& info_vec) const noexcept;
     bool drop_indexes() noexcept;
 private:
-    QofBackend* m_qbe;
+    QofBackend* m_qbe = nullptr;
     dbi_conn m_conn;
     std::unique_ptr<GncDbiProvider> m_provider;
     /** Used by the error handler routines to flag if the connection is ok to
diff --git a/libgnucash/backend/dbi/gnc-dbisqlresult.hpp b/libgnucash/backend/dbi/gnc-dbisqlresult.hpp
index c0dd59e..52da0d2 100644
--- a/libgnucash/backend/dbi/gnc-dbisqlresult.hpp
+++ b/libgnucash/backend/dbi/gnc-dbisqlresult.hpp
@@ -63,11 +63,11 @@ protected:
             return dbi_result_field_is_null(m_inst->m_dbi_result, col);
         }
     private:
-        GncDbiSqlResult* m_inst;
+        GncDbiSqlResult* m_inst = nullptr;
     };
 
 private:
-    const GncDbiSqlConnection* m_conn;
+    const GncDbiSqlConnection* m_conn = nullptr;
     dbi_result m_dbi_result;
     IteratorImpl m_iter;
     GncSqlRow m_row;
diff --git a/libgnucash/backend/sql/gnc-sql-backend.hpp b/libgnucash/backend/sql/gnc-sql-backend.hpp
index 1d8a97c..bde8700 100644
--- a/libgnucash/backend/sql/gnc-sql-backend.hpp
+++ b/libgnucash/backend/sql/gnc-sql-backend.hpp
@@ -241,12 +241,12 @@ public:
     void finish_progress() const noexcept;
 
 protected:
-    GncSqlConnection* m_conn;  /**< SQL connection */
-    QofBook* m_book;           /**< The primary, main open book */
+    GncSqlConnection* m_conn = nullptr;  /**< SQL connection */
+    QofBook* m_book = nullptr;           /**< The primary, main open book */
     bool m_loading;        /**< We are performing an initial load */
     bool m_in_query;       /**< We are processing a query */
     bool m_is_pristine_db; /**< Are we saving to a new pristine db? */
-    const char* m_timespec_format; /**< Server-specific date-time string format */
+    const char* m_timespec_format = nullptr; /**< Server-specific date-time string format */
     VersionVec m_versions;    /**< Version number for each table */
 private:
     bool write_account_tree(Account*);
diff --git a/libgnucash/backend/sql/gnc-sql-column-table-entry.hpp b/libgnucash/backend/sql/gnc-sql-column-table-entry.hpp
index 3ded4c4..b365d4a 100644
--- a/libgnucash/backend/sql/gnc-sql-column-table-entry.hpp
+++ b/libgnucash/backend/sql/gnc-sql-column-table-entry.hpp
@@ -231,12 +231,12 @@ protected:
  */
     void add_objectref_guid_to_table (ColVec& vec) const noexcept;
 private:
-    const char* m_col_name;        /**< Column name */
+    const char* m_col_name = nullptr;        /**< Column name */
     const GncSqlObjectType m_col_type;        /**< Column type */
     unsigned int m_size;       /**< Column size in bytes, for string columns */
     ColumnFlags m_flags;           /**< Column flags */
-    const char* m_gobj_param_name; /**< If non-null, g_object param name */
-    const char* m_qof_param_name;  /**< If non-null, qof parameter name */
+    const char* m_gobj_param_name = nullptr; /**< If non-null, g_object param name */
+    const char* m_qof_param_name = nullptr;  /**< If non-null, qof parameter name */
     QofAccessFunc m_getter;        /**< General access function */
     QofSetterFunc m_setter;        /**< General setter function */
     template <typename T> T get_row_value_from_object(QofIdTypeConst obj_name,
diff --git a/libgnucash/backend/sql/gnc-sql-object-backend.hpp b/libgnucash/backend/sql/gnc-sql-object-backend.hpp
index 316e64d..bd3f705 100644
--- a/libgnucash/backend/sql/gnc-sql-object-backend.hpp
+++ b/libgnucash/backend/sql/gnc-sql-object-backend.hpp
@@ -131,9 +131,9 @@ struct write_objects_t
     void commit (QofInstance* inst) {
         if (is_ok) is_ok = obe->commit (be, inst);
     }
-    GncSqlBackend* be;
-    bool is_ok;
-    GncSqlObjectBackend* obe;
+    GncSqlBackend* be = nullptr;
+    bool is_ok = false;
+    GncSqlObjectBackend* obe = nullptr;
 };
 
 
diff --git a/libgnucash/engine/test/test-kvp-frame.cpp b/libgnucash/engine/test/test-kvp-frame.cpp
index 9e0491c..29a162c 100644
--- a/libgnucash/engine/test/test-kvp-frame.cpp
+++ b/libgnucash/engine/test/test-kvp-frame.cpp
@@ -42,8 +42,8 @@ public:
     }
 protected:
     KvpFrameImpl t_root;
-    KvpValue *t_int_val;
-    KvpValue *t_str_val;
+    KvpValue *t_int_val = nullptr;
+    KvpValue *t_str_val = nullptr;
 };
 
 template <typename A, typename B> void



Summary of changes:
 libgnucash/backend/dbi/gnc-dbisqlconnection.cpp       | 2 +-
 libgnucash/backend/dbi/gnc-dbisqlconnection.hpp       | 2 +-
 libgnucash/backend/dbi/gnc-dbisqlresult.hpp           | 4 ++--
 libgnucash/backend/sql/gnc-sql-backend.hpp            | 6 +++---
 libgnucash/backend/sql/gnc-sql-column-table-entry.hpp | 6 +++---
 libgnucash/backend/sql/gnc-sql-object-backend.hpp     | 6 +++---
 libgnucash/engine/test/test-kvp-frame.cpp             | 4 ++--
 7 files changed, 15 insertions(+), 15 deletions(-)



More information about the gnucash-changes mailing list