gnucash maint: Bug 796248 - Editing Scheduled Transaction

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/ffe6044c (commit)
	from  https://github.com/Gnucash/gnucash/commit/c8861d46 (commit)



commit ffe6044cd66edf39ae22875ef475d8e655b93526
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Jun 12 15:49:28 2018 -0700

    Bug 796248 - Editing Scheduled Transaction
    
    An extra XaccTransBeginEdit, never committed, for transactions that
    the backend tried to load when they were already there. That made
    the register think that something else had it open.

diff --git a/libgnucash/backend/sql/gnc-transaction-sql.cpp b/libgnucash/backend/sql/gnc-transaction-sql.cpp
index f2e2b1f..c62f3f1 100644
--- a/libgnucash/backend/sql/gnc-transaction-sql.cpp
+++ b/libgnucash/backend/sql/gnc-transaction-sql.cpp
@@ -292,12 +292,12 @@ load_single_tx (GncSqlBackend* sql_be, GncSqlRow& row)
     if (guid == NULL) return NULL;
     tx_guid = *guid;
 
-    // Don't overwrite the transaction if it's already been loaded (and possibly modified).
-    // However increase the edit level, it may be modified while loading its splits
+    /* Don't overwrite the transaction if it's already been loaded (and possibly
+     * modified).
+     */
     pTx = xaccTransLookup (&tx_guid, sql_be->book());
     if (pTx != NULL)
     {
-        xaccTransBeginEdit (pTx);
         return NULL;
     }
 



Summary of changes:
 libgnucash/backend/sql/gnc-transaction-sql.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)