gnucash maint: An empty GValue is interpreted as NULL reason, which is still a valid cache

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/1117027f (commit)
	from  https://github.com/Gnucash/gnucash/commit/a19dcc7b (commit)



commit 1117027f72580d2628f084931deec96229a63317
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Mon Sep 10 10:24:49 2018 +0200

    An empty GValue is interpreted as NULL reason, which is still a valid cache
    
    Ignoring this would make caching almost useless as there are typically
    only very few read-only transactions.

diff --git a/libgnucash/engine/Transaction.c b/libgnucash/engine/Transaction.c
index 1ddf183..c8320d3 100644
--- a/libgnucash/engine/Transaction.c
+++ b/libgnucash/engine/Transaction.c
@@ -2472,8 +2472,8 @@ xaccTransGetReadOnly (Transaction *trans)
         {
             trans->readonly_reason = g_value_dup_string (&v);
             g_value_unset (&v);
-            trans->reason_cache_valid = TRUE;
         }
+        trans->reason_cache_valid = TRUE;
     }
     return trans->readonly_reason;
 }



Summary of changes:
 libgnucash/engine/Transaction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)