gnucash maint: Bug 797230 - Use after free in

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/7b6b8600 (commit)
	from  https://github.com/Gnucash/gnucash/commit/48c3c8bc (commit)



commit 7b6b86000dd0894ecb75e52fe9810be6feb93763
Author: Christopher Zimmermann <christopher at gmerlin.de>
Date:   Thu May 9 19:13:41 2019 -0500

    Bug 797230 - Use after free in
    
    gnucash__sheet_style_destroy.

diff --git a/gnucash/register/register-gnome/gnucash-style.c b/gnucash/register/register-gnome/gnucash-style.c
index f2a04fbdf..37fa3f0af 100644
--- a/gnucash/register/register-gnome/gnucash-style.c
+++ b/gnucash/register/register-gnome/gnucash-style.c
@@ -709,9 +709,9 @@ gnucash_sheet_style_destroy (GnucashSheet *sheet, SheetBlockStyle *style)
 
     if (style->dimensions->refcount == 0)
     {
+        style_dimensions_destroy (style->dimensions);
         g_hash_table_remove (sheet->dimensions_hash_table,
                              style_get_key (style));
-        style_dimensions_destroy (style->dimensions);
     }
 
     g_free (style);



Summary of changes:
 gnucash/register/register-gnome/gnucash-style.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)