gnucash maint: Bug 797241 - Some reports skip transactions of the last day of the selected period

Christopher Lam clam at code.gnucash.org
Fri May 17 11:08:48 EDT 2019


Updated	 via  https://github.com/Gnucash/gnucash/commit/b26276cb (commit)
	from  https://github.com/Gnucash/gnucash/commit/416b79d3 (commit)



commit b26276cba4229c399a38158bb877c6be1e66584f
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri May 17 23:05:56 2019 +0800

    Bug 797241 - Some reports skip transactions of the last day of the selected period
    
    portfolio.scm and advanced-portfolio.scm were not taking into account
    transactions dated on the report-date. expand query so that end-date
    is 23:59:59 rather than somewhere mid-day.

diff --git a/gnucash/report/standard-reports/advanced-portfolio.scm b/gnucash/report/standard-reports/advanced-portfolio.scm
index 44bd6293b..8e7bfc01e 100644
--- a/gnucash/report/standard-reports/advanced-portfolio.scm
+++ b/gnucash/report/standard-reports/advanced-portfolio.scm
@@ -997,8 +997,9 @@ by preventing negative stock balances.<br/>")
   ;; The first thing we do is make local variables for all the specific
   ;; options in the set of options given to the function. This set will
   ;; be generated by the options generator above.
-  (let ((to-date     (gnc:date-option-absolute-time
-                      (get-option gnc:pagename-general "Date")))
+  (let ((to-date     (gnc:time64-end-day-time
+                      (gnc:date-option-absolute-time
+                       (get-option gnc:pagename-general "Date"))))
         (accounts    (get-option gnc:pagename-accounts "Accounts"))
         (currency    (get-option gnc:pagename-general "Report's currency"))
         (price-source (get-option gnc:pagename-general
diff --git a/gnucash/report/standard-reports/portfolio.scm b/gnucash/report/standard-reports/portfolio.scm
index c4faa6872..95f1df272 100644
--- a/gnucash/report/standard-reports/portfolio.scm
+++ b/gnucash/report/standard-reports/portfolio.scm
@@ -170,8 +170,9 @@
   ;; The first thing we do is make local variables for all the specific
   ;; options in the set of options given to the function. This set will
   ;; be generated by the options generator above.
-  (let ((to-date     (gnc:date-option-absolute-time
-                      (get-option gnc:pagename-general "Date")))
+  (let ((to-date     (gnc:time64-end-day-time
+                      (gnc:date-option-absolute-time
+                       (get-option gnc:pagename-general "Date"))))
         (accounts    (get-option gnc:pagename-accounts "Accounts"))
         (currency    (get-option gnc:pagename-general "Report's currency"))
         (report-title (get-option gnc:pagename-general



Summary of changes:
 gnucash/report/standard-reports/advanced-portfolio.scm | 5 +++--
 gnucash/report/standard-reports/portfolio.scm          | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)



More information about the gnucash-changes mailing list