gnucash maint: Fix segfault in test-portfolios after debug build.

John Ralls jralls at code.gnucash.org
Sat Oct 12 12:43:19 EDT 2019


Updated	 via  https://github.com/Gnucash/gnucash/commit/57e403b0 (commit)
	from  https://github.com/Gnucash/gnucash/commit/4c790b20 (commit)



commit 57e403b048083d7592450cf832aebb81de8b3681
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Oct 12 09:29:40 2019 -0700

    Fix segfault in test-portfolios after debug build.
    
    gnc-clear-current-session deletes the pricedb so deleting it first
    is unnecessary. Deleting it first and not nulling the pointer in
    the book leads to accessing freed memory, and debug mode poisons
    that to force a crash when it happens.

diff --git a/gnucash/report/standard-reports/test/test-portfolios.scm b/gnucash/report/standard-reports/test/test-portfolios.scm
index 6ce643e8e..c72ac8261 100644
--- a/gnucash/report/standard-reports/test/test-portfolios.scm
+++ b/gnucash/report/standard-reports/test/test-portfolios.scm
@@ -56,9 +56,6 @@
         (test-assert (format #f "wrong-option ~a ~a" section name) #f))))
 
 (define (teardown)
-  (gnc-pricedb-destroy
-   (gnc-pricedb-get-db
-    (gnc-get-current-book)))
   (gnc-clear-current-session))
 
 (define (null-test variant uuid)



Summary of changes:
 gnucash/report/standard-reports/test/test-portfolios.scm | 3 ---
 1 file changed, 3 deletions(-)



More information about the gnucash-changes mailing list