gnucash maint: Multiple changes pushed
Christopher Lam
clam at code.gnucash.org
Sun Aug 16 05:56:37 EDT 2020
Updated via https://github.com/Gnucash/gnucash/commit/088a386d (commit)
via https://github.com/Gnucash/gnucash/commit/00efc169 (commit)
from https://github.com/Gnucash/gnucash/commit/3e0eda4b (commit)
commit 088a386dc7aa643269f665c1cb5df77e78f3c020
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sun Aug 16 17:55:00 2020 +0800
[gnc-plugin-page-register.c] sanity check invoices_from_transaction
prevent segfault if trans is NULL. would crash when deleting a split.
diff --git a/gnucash/gnome/gnc-plugin-page-register.c b/gnucash/gnome/gnc-plugin-page-register.c
index bcf006f73..f8d4034b1 100644
--- a/gnucash/gnome/gnc-plugin-page-register.c
+++ b/gnucash/gnome/gnc-plugin-page-register.c
@@ -4590,6 +4590,8 @@ static GncInvoice* invoice_from_split (Split* split)
GList* invoices_from_transaction (Transaction* trans)
{
GList *invoices = NULL;
+ if (!trans) return NULL;
+
for (GList *node = xaccTransGetAPARAcctSplitList(trans, TRUE); node;
node = node->next)
{
commit 00efc1696a8c8521cda8791f113ae83cf58240f8
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sun Aug 16 17:54:24 2020 +0800
[Transaction.c] sanity check xaccTransGetAPARAcctSplitList
prevent segfault if trans is NULL
diff --git a/libgnucash/engine/Transaction.c b/libgnucash/engine/Transaction.c
index 477ecb034..74e7f9741 100644
--- a/libgnucash/engine/Transaction.c
+++ b/libgnucash/engine/Transaction.c
@@ -2266,6 +2266,8 @@ SplitList *
xaccTransGetAPARAcctSplitList (const Transaction *trans, gboolean strict)
{
GList *apar_splits = NULL;
+ if (!trans) return NULL;
+
FOR_EACH_SPLIT (trans,
const Account *account = xaccSplitGetAccount(s);
if (account && xaccAccountIsAPARType(xaccAccountGetType(account)))
Summary of changes:
gnucash/gnome/gnc-plugin-page-register.c | 2 ++
libgnucash/engine/Transaction.c | 2 ++
2 files changed, 4 insertions(+)
More information about the gnucash-changes
mailing list