gnucash maint: Bug 798041 - Open invoices in new window does not work

[Robert Fewell]

Updated	 via  https://github.com/Gnucash/gnucash/commit/3e76b844 (commit)
	from  https://github.com/Gnucash/gnucash/commit/48f6cc14 (commit)



commit 3e76b84475d1c6db3a68b3930b41f1ef24f9d7f9
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Fri Dec 11 13:26:34 2020 +0000

    Bug 798041 - Open invoices in new window does not work
    
    If you set the preference setting to open invoices in a new window the
    invoice still opens in new tab. This setting was being over ridden in
    gnc_invoice_new_page so removed that in the function.

diff --git a/gnucash/gnome/dialog-invoice.c b/gnucash/gnome/dialog-invoice.c
index ac97a53ff..70a629224 100644
--- a/gnucash/gnome/dialog-invoice.c
+++ b/gnucash/gnome/dialog-invoice.c
@@ -2275,9 +2275,8 @@ gnc_invoice_new_page (QofBook *bookp, InvoiceDialogType type,
 
     /* Now create the plugin page for this invoice and display it. */
     new_page = gnc_plugin_page_invoice_new (iw);
-    if (window)
-        gnc_plugin_page_set_use_new_window (new_page, FALSE);
-    else
+
+    if (!window)
         window = gnc_plugin_business_get_window ();
 
     gnc_main_window_open_page (window, new_page);



Summary of changes:
 gnucash/gnome/dialog-invoice.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)