gnucash maint: [c-interface] internal defines must be declared first

Christopher Lam clam at code.gnucash.org
Thu Dec 24 09:09:04 EST 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/0510ecfe (commit)
	from  https://github.com/Gnucash/gnucash/commit/bf671d4f (commit)



commit 0510ecfe85f9771e82ab10e45336befe54e8d207
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Dec 24 21:05:57 2020 +0800

    [c-interface] internal defines must be declared first
    
    An internal (define) cannot be after a statement such
    as (issue-deprecation-warning). This rule was strict in guile-2.2 but
    relaxed in guile-3.0, hence, the mixed results in CI.

diff --git a/libgnucash/app-utils/c-interface.scm b/libgnucash/app-utils/c-interface.scm
index 4a1df47e9..c4a414803 100644
--- a/libgnucash/app-utils/c-interface.scm
+++ b/libgnucash/app-utils/c-interface.scm
@@ -88,9 +88,9 @@
 ;; strings. Strings that are returned by the lookup function are
 ;; translated with gettext.
 (define (gnc:make-string-database)
+  (define string-hash (make-hash-table))
   (issue-deprecation-warning "gnc:make-string-database is deprecated. It \
 will be removed in GnuCash 5.x")
-  (define string-hash (make-hash-table))
   (lambda args
     (match args
       (('lookup key) (G_ (hash-ref string-hash key)))



Summary of changes:
 libgnucash/app-utils/c-interface.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



More information about the gnucash-changes mailing list