gnucash maint: Travis - use ctest built-in feature to verbosely log test failures

Geert Janssens gjanssens at code.gnucash.org
Sat Feb 29 06:58:30 EST 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/b5dfef62 (commit)
	from  https://github.com/Gnucash/gnucash/commit/95857a8b (commit)



commit b5dfef628eda8f91bb33ece2b11a1f23b64e9e34
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Feb 29 10:51:49 2020 +0100

    Travis - use ctest built-in feature to verbosely log test failures
    
    Setting CTEST_OUTPUT_ON_FAILURE will cause ctest to log all
    output from failing tests (and only from failing tests).
    This will reduce our ci output in case of failures as our
    homebrew script 'afterfailure' would output all test logs
    in case of failure not only the output of failed tests.

diff --git a/util/ci/afterfailure b/util/ci/afterfailure
deleted file mode 100755
index dd065c193..000000000
--- a/util/ci/afterfailure
+++ /dev/null
@@ -1,12 +0,0 @@
-#!/bin/bash
-
-if [[ "$BUILDTYPE" == "cmake-make" ]] || [[ "$BUILDTYPE" == "cmake-ninja" ]]; then
-    echo "########################";
-    echo "##### LastTest.log #####";
-    echo "########################";
-    cat /build/Testing/Temporary/LastTest.log;
-else
-    echo "Unknown BUILDTYPE: \"$BUILDTYPE\", cannot create failure information.";
-fi
-# This script should fail so that the entire script will fail.
-exit 1;
diff --git a/util/ci/commonbuild b/util/ci/commonbuild
index 9b1875d55..cf27b1286 100644
--- a/util/ci/commonbuild
+++ b/util/ci/commonbuild
@@ -5,15 +5,16 @@ mkdir -p "$HOME"/.local/share
 mkdir build
 cd build
 export TZ="America/Los_Angeles"
+export CTEST_OUTPUT_ON_FAILURE=On
 
 if [[ "$BUILDTYPE" == "cmake-make" ]]; then
     cmake ../gnucash $PLATFORM_CMAKE_OPTS
     make -j 4
-    make check || ../afterfailure
+    make check
 elif [[ "$BUILDTYPE" == "cmake-ninja" ]]; then
     cmake ../gnucash -DWITH_PYTHON=ON -DCMAKE_BUILD_TYPE=debug -G Ninja $PLATFORM_CMAKE_OPTS
     ninja
-    ninja check || ../afterfailure;
+    ninja check
 else
     echo "Unknown buildtype: \"$BUILDTYPE\". Not building."
 fi



Summary of changes:
 util/ci/afterfailure | 12 ------------
 util/ci/commonbuild  |  5 +++--
 2 files changed, 3 insertions(+), 14 deletions(-)
 delete mode 100755 util/ci/afterfailure



More information about the gnucash-changes mailing list