gnucash maint: Multiple changes pushed

Robert Fewell bobit at code.gnucash.org
Wed Jul 22 07:45:24 EDT 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/ee230a6c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/40d63d47 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/2feabc7c (commit)
	from  https://github.com/Gnucash/gnucash/commit/a93f3c19 (commit)



commit ee230a6cca3cfca9f9e4a8860436e39aae29ab98
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Jul 22 12:35:48 2020 +0100

    Bug 797842 - Empty Entry widgets not showing insertion cursor
    
    On windows 10, if the font has been specified in CSS with 'sans-serif',
    the insertion cursor on an empty entry widget is not shown. Choosing a
    different font such as 'arial' is OK. As reporter based there changes
    on the example CSS file remove the reference to 'sans-serif'

diff --git a/doc/gtk-3.0.css b/doc/gtk-3.0.css
index ad780199a..cccae3594 100755
--- a/doc/gtk-3.0.css
+++ b/doc/gtk-3.0.css
@@ -22,7 +22,7 @@
 
 /* Application wide font setting */
 * {
-  font: 12px arial, sans-serif;
+  font: 12px arial;
 }
 
 
@@ -40,7 +40,7 @@ scrollbar slider {
 
 /* Register sheet font setting */
 gnc-id-sheet {
-  font: 10px arial, sans-serif;
+  font: 10px arial;
 }
 
 
@@ -65,7 +65,7 @@ gnc-id-cursor button {
 
 /* Register sheet calendar */
 gnc-id-sheet calendar {
-  font: 13px arial, sans-serif;
+  font: 13px arial;
   background-color:lightgreen;
   border-color: green;
   border-width: 1px;

commit 40d63d478b66d1740969c70cf7f014ee78f4cab3
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Jul 22 10:23:58 2020 +0100

    Add missing LEAVE macro to gnc-tree-model-account.c

diff --git a/gnucash/gnome-utils/gnc-tree-model-account.c b/gnucash/gnome-utils/gnc-tree-model-account.c
index 810d2a05f..0a93faf4d 100644
--- a/gnucash/gnome-utils/gnc-tree-model-account.c
+++ b/gnucash/gnome-utils/gnc-tree-model-account.c
@@ -741,6 +741,7 @@ gnc_tree_model_account_get_value (GtkTreeModel *tree_model,
     {
         g_value_init (value, G_TYPE_STRING);
         g_value_take_string (value, cached_string);
+        LEAVE("value in cache, '%s'", cached_string);
         return;
     }
 

commit 2feabc7ca2157bc6b819f22590c6bd5376498e60
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Wed Jul 22 10:00:01 2020 +0100

    Bug 797787 - Create new plugin page next to current page
    
    Currently new pages are created in the last position which
    could result in a lot of scrolling if a large number of
    tabs are open. This commit changes that so new pages are
    created next to the current page.

diff --git a/gnucash/gnome-utils/gnc-main-window.c b/gnucash/gnome-utils/gnc-main-window.c
index 36c5a85ba..312d12131 100644
--- a/gnucash/gnome-utils/gnc-main-window.c
+++ b/gnucash/gnome-utils/gnc-main-window.c
@@ -2809,17 +2809,20 @@ gnc_main_window_connect (GncMainWindow *window,
 {
     GncMainWindowPrivate *priv;
     GtkNotebook *notebook;
+    gint current_position = -1;
 
     page->window = GTK_WIDGET(window);
     priv = GNC_MAIN_WINDOW_GET_PRIVATE(window);
     notebook = GTK_NOTEBOOK (priv->notebook);
-    priv->installed_pages = g_list_append (priv->installed_pages, page);
+    current_position = g_list_index (priv->installed_pages, priv->current_page) + 1;
+    priv->installed_pages = g_list_insert (priv->installed_pages, page, current_position);
     priv->usage_order = g_list_prepend (priv->usage_order, page);
-    gtk_notebook_append_page_menu (notebook, page->notebook_page,
-                                   tab_hbox, menu_label);
+    gtk_notebook_insert_page_menu (notebook, page->notebook_page,
+                                   tab_hbox, menu_label, current_position);
     gtk_notebook_set_tab_reorderable (notebook, page->notebook_page, TRUE);
     gnc_plugin_page_inserted (page);
-    gtk_notebook_set_current_page (notebook, -1);
+    gtk_notebook_set_current_page (notebook, current_position);
+
     if (GNC_PLUGIN_PAGE_GET_CLASS(page)->window_changed)
         (GNC_PLUGIN_PAGE_GET_CLASS(page)->window_changed)(page, GTK_WIDGET(window));
     g_signal_emit (window, main_window_signals[PAGE_ADDED], 0, page);



Summary of changes:
 doc/gtk-3.0.css                              |  6 +++---
 gnucash/gnome-utils/gnc-main-window.c        | 11 +++++++----
 gnucash/gnome-utils/gnc-tree-model-account.c |  1 +
 3 files changed, 11 insertions(+), 7 deletions(-)



More information about the gnucash-changes mailing list