gnucash-on-windows master: Force consistent download filename for signing key

Geert Janssens gjanssens at code.gnucash.org
Thu Jun 11 04:33:42 EDT 2020


Updated	 via  https://github.com/Gnucash/gnucash-on-windows/commit/bac5a52d (commit)
	from  https://github.com/Gnucash/gnucash-on-windows/commit/47ce0f7a (commit)



commit bac5a52d0ddef6c38b24719d9ed40042fcd355a1
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Thu Jun 11 10:33:34 2020 +0200

    Force consistent download filename for signing key
    
    By default wget will append a number to the downloaded file if
    a file by that name already exists. This can lead to the wrong
    (old) signing key to be passed to pacman if it was updated
    upstream and the previous one was still downloaded.
    Explicitly setting an output filename will force reuse of that
    name. Note this works well in this context only because
    we know we're only downloading a single file. It would not
    work for a multi-file download.

diff --git a/setup-mingw64.ps1 b/setup-mingw64.ps1
index 146eb76..787d9db 100644
--- a/setup-mingw64.ps1
+++ b/setup-mingw64.ps1
@@ -257,7 +257,7 @@ $key_url = $sourceforge_url + $signing_keyfile
 $key_id = "C1F4DE993CF5835F"
 $webkit = "$arch_long-webkitgtk3-2.4.11-999.3-any.pkg.tar.zst"
 $webkit_url = $sourceforge_url + $webkit
-bash-command -command "wget $key_url"
+bash-command -command "wget $key_url -O $signing_keyfile"
 bash-command -command "pacman-key --add $signing_keyfile"
 bash-command -command "pacman-key --lsign $key_id"
 bash-command -command "pacman -U $webkit_url --noconfirm --needed"



Summary of changes:
 setup-mingw64.ps1 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



More information about the gnucash-changes mailing list