gnucash master: Error in trace file for Dialog Options

Robert Fewell bobit at code.gnucash.org
Sun Jun 14 08:00:48 EDT 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/4ca52b23 (commit)
	from  https://github.com/Gnucash/gnucash/commit/1d055b6d (commit)



commit 4ca52b2380107651679bd33ede1565b17ce74d90
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sun Jun 14 12:58:57 2020 +0100

    Error in trace file for Dialog Options
    
    When the New Account Hierarchy Assistant is used, the book options are
    added to the assistant as a notebook page and so will not have a parent
    widget to be used when restoring the window size so test for parent
    before using gnc_restore_window_size

diff --git a/gnucash/gnome-utils/dialog-options.c b/gnucash/gnome-utils/dialog-options.c
index c6f48c1a7..50a654ee0 100644
--- a/gnucash/gnome-utils/dialog-options.c
+++ b/gnucash/gnome-utils/dialog-options.c
@@ -2273,7 +2273,8 @@ gnc_options_dialog_new_modal(gboolean modal, gchar *title,
 
     gtk_builder_connect_signals_full (builder, gnc_builder_connect_full_func, retval);
 
-    gnc_restore_window_size (GNC_PREFS_GROUP, GTK_WINDOW(retval->window), parent);
+    if (parent) // when added to a page of the hierarchy assistant there will be no parent
+        gnc_restore_window_size (GNC_PREFS_GROUP, GTK_WINDOW(retval->window), parent);
 
     if (title)
         gtk_window_set_title(GTK_WINDOW(retval->window), title);



Summary of changes:
 gnucash/gnome-utils/dialog-options.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)



More information about the gnucash-changes mailing list