gnucash master: Bug 797830 - Expense over time has extra empty row
Christopher Lam
clam at code.gnucash.org
Tue Jun 30 09:52:03 EDT 2020
Updated via https://github.com/Gnucash/gnucash/commit/7d02897d (commit)
from https://github.com/Gnucash/gnucash/commit/2610b5f5 (commit)
commit 7d02897dd222ea71b597674327a76b4e9cd2057a
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Tue Jun 30 21:48:20 2020 +0800
Bug 797830 - Expense over time has extra empty row
This is a *subtle* bug.
1. dates-list is the list of report-dates at periodic intervals
2. if an interval report (i.e. inc/exp) is chosen, we want to omit the
last one, because the report analyses changes in value between
adjacent dates.
3. dates-list was appropriately redefined to be 1 element shorter than
the original dates-list.
4. date-string-list (for display labels) was meant to pick up the
shorter dates-list, formatted via qof-print-date.
Unfortunately the let statement had defined both dates-list and
date-string-list at the same time, therefore date-string-list did not
pick up the redefined dates-list. Using let* instead means it uses the
shorter dates-list, and omits the last element as intended for display.
diff --git a/gnucash/report/reports/standard/category-barchart.scm b/gnucash/report/reports/standard/category-barchart.scm
index fdf06a371..26389e1b3 100644
--- a/gnucash/report/reports/standard/category-barchart.scm
+++ b/gnucash/report/reports/standard/category-barchart.scm
@@ -495,10 +495,11 @@ developing over time"))
(and (not (null? all-data))
(not-all-zeros (map cadr all-data)))
- (let ((dates-list (if do-intervals?
- (list-head dates-list (1- (length dates-list)))
- dates-list))
- (date-string-list (map qof-print-date dates-list)))
+ (let* ((dates-list (if do-intervals?
+ (list-head dates-list (1- (length dates-list)))
+ dates-list))
+ (date-string-list (map qof-print-date dates-list)))
+
;; Set chart title, subtitle etc.
(gnc:html-chart-set-type!
Summary of changes:
gnucash/report/reports/standard/category-barchart.scm | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
More information about the gnucash-changes
mailing list