gnucash maint: Multiple changes pushed

Frank H.Ellenberger fell at code.gnucash.org
Fri Mar 13 16:46:31 EDT 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/82987e13 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/56fa959e (commit)
	from  https://github.com/Gnucash/gnucash/commit/74e66acd (commit)



commit 82987e13f38953026d3e6c969c25cc00baeb49e1
Author: Frank H. Ellenberger <frank.h.ellenberger at gmail.com>
Date:   Fri Mar 13 21:22:19 2020 +0100

    gnc-fq-dump: fix warning on argv
    
    Scalar value @ARGV[0] better written as $ARGV[0] at gnc-fq-dump line
    160.

diff --git a/libgnucash/quotes/gnc-fq-dump.in b/libgnucash/quotes/gnc-fq-dump.in
index 8362b51f5..e44082cc6 100755
--- a/libgnucash/quotes/gnc-fq-dump.in
+++ b/libgnucash/quotes/gnc-fq-dump.in
@@ -157,7 +157,7 @@ if ($#ARGV < 1) {
 }
 
 my $verbose = 0;
-if (@ARGV[0] eq "-v") {
+if ($ARGV[0] eq "-v") {
   $verbose = 1;
   shift;
 }

commit 56fa959ec08b5038d5b10c7eab58e9e9ebafc8db
Author: Frank H. Ellenberger <frank.h.ellenberger at gmail.com>
Date:   Fri Mar 13 20:53:15 2020 +0100

    Apply @PERL@ -w substitution on gnc-fq-dump, too

diff --git a/libgnucash/quotes/CMakeLists.txt b/libgnucash/quotes/CMakeLists.txt
index 966b38a69..b33569d39 100644
--- a/libgnucash/quotes/CMakeLists.txt
+++ b/libgnucash/quotes/CMakeLists.txt
@@ -1,6 +1,6 @@
 
 set(_BIN_FILES "")
-foreach(file gnc-fq-check.in gnc-fq-helper.in gnc-fq-update.in gnc-fq-dump)
+foreach(file gnc-fq-check.in gnc-fq-helper.in gnc-fq-update.in gnc-fq-dump.in)
   string(REPLACE ".in" "" _OUTPUT_FILE_NAME ${file})
   set(_ABS_OUTPUT_FILE ${BINDIR_BUILD}/${_OUTPUT_FILE_NAME})
   configure_file( ${file} ${_ABS_OUTPUT_FILE} @ONLY)
@@ -26,4 +26,4 @@ add_custom_target(quotes-bin ALL DEPENDS ${_BIN_FILES})
 install(FILES ${_MAN_FILES} DESTINATION  ${CMAKE_INSTALL_MANDIR}/man1)
 install(PROGRAMS ${_BIN_FILES} DESTINATION ${CMAKE_INSTALL_BINDIR})
 
-set_dist_list(quotes_DIST CMakeLists.txt gnc-fq-check.in gnc-fq-dump gnc-fq-helper.in gnc-fq-update.in Quote_example.pl README)
+set_dist_list(quotes_DIST CMakeLists.txt gnc-fq-check.in gnc-fq-dump.in gnc-fq-helper.in gnc-fq-update.in Quote_example.pl README)
diff --git a/libgnucash/quotes/README b/libgnucash/quotes/README
index 9b56df81a..44c8fcc11 100644
--- a/libgnucash/quotes/README
+++ b/libgnucash/quotes/README
@@ -8,11 +8,11 @@ gnc-fq-check.in:
   gnucash to determine if Finance::Quote is installed properly.  The
   responses is a scheme form.
 
-gnc-fq-dump:
+gnc-fq-dump.in:
 
-  A perl script that retrieves a quote from Finance::Quote and dumps
-  the response to the terminal.  Its useful for determining problems
-  with F::Q.
+  Source file for gnc-fq-dump which is a perl script that retrieves
+  a quote from Finance::Quote and dumps the response to the terminal.
+  Its useful for determining problems with F::Q.
 
 gnc-fq-helper.in:
 
diff --git a/libgnucash/quotes/gnc-fq-dump b/libgnucash/quotes/gnc-fq-dump.in
similarity index 99%
rename from libgnucash/quotes/gnc-fq-dump
rename to libgnucash/quotes/gnc-fq-dump.in
index e87e55cc7..8362b51f5 100755
--- a/libgnucash/quotes/gnc-fq-dump
+++ b/libgnucash/quotes/gnc-fq-dump.in
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!@PERL@ -w
 #
 #    Copyright (C) 2003, David Hampton <hampton at employees.org>
 #



Summary of changes:
 libgnucash/quotes/CMakeLists.txt                  | 4 ++--
 libgnucash/quotes/README                          | 8 ++++----
 libgnucash/quotes/{gnc-fq-dump => gnc-fq-dump.in} | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)
 rename libgnucash/quotes/{gnc-fq-dump => gnc-fq-dump.in} (99%)



More information about the gnucash-changes mailing list