gnucash maint: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/af298a2e (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5a69ff23 (commit)
	from  https://github.com/Gnucash/gnucash/commit/2c956225 (commit)



commit af298a2e38f801db16969624d018a7a5c3303151
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Mar 19 17:43:23 2020 -0700

    Fix crash when changing account-separator.
    
    Unregister the handler from the same scheme in which it was registered,
    otherwise zombie handlers get called, and crash.

diff --git a/gnucash/gnome-utils/account-quickfill.c b/gnucash/gnome-utils/account-quickfill.c
index b6ddccb81..2d3d808fd 100644
--- a/gnucash/gnome-utils/account-quickfill.c
+++ b/gnucash/gnome-utils/account-quickfill.c
@@ -65,7 +65,7 @@ static void
 shared_quickfill_destroy (QofBook *book, gpointer key, gpointer user_data)
 {
     QFB *qfb = user_data;
-    gnc_prefs_remove_cb_by_func (GNC_PREFS_GROUP_GENERAL_REGISTER,
+    gnc_prefs_remove_cb_by_func (GNC_PREFS_GROUP_GENERAL,
                                  GNC_PREF_ACCOUNT_SEPARATOR,
                                  shared_quickfill_pref_changed,
                                  qfb);

commit 5a69ff2315d72fd38e17a9be82ad1456494f3f03
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Mar 19 15:48:38 2020 -0700

    Fix crash on completion of OFX download.
    
    gtk_grid_remove_row has already destroyed the box so attempting
    to gtk_widget_destroy it can lead to a crash.

diff --git a/gnucash/import-export/aqb/gnc-gwen-gui.c b/gnucash/import-export/aqb/gnc-gwen-gui.c
index 7f5277a69..1352d2c16 100644
--- a/gnucash/import-export/aqb/gnc-gwen-gui.c
+++ b/gnucash/import-export/aqb/gnc-gwen-gui.c
@@ -891,7 +891,7 @@ hide_progress(GncGWENGui *gui, Progress *progress)
                 /* Last other progress to be hidden */
                 gtk_grid_remove_row (GTK_GRID(gui->entries_grid),
                                      OTHER_ENTRIES_ROW_OFFSET);
-                gtk_widget_destroy(box);
+                /* Box destroyed, Null the reference. */
                 gui->other_entries_box = NULL;
             }
             g_list_free(entries);



Summary of changes:
 gnucash/gnome-utils/account-quickfill.c  | 2 +-
 gnucash/import-export/aqb/gnc-gwen-gui.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)