gnucash maint: Bug 797084 - Provide an option to leave edited transactions reconciled

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/fdd47985 (commit)
	from  https://github.com/Gnucash/gnucash/commit/5b18405c (commit)



commit fdd4798555eaaf1025e9f9d2c485254d4ddf532d
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Mar 28 16:04:25 2020 +0100

    Bug 797084 - Provide an option to leave edited transactions reconciled
    
    Instead of making this optional, changes to transaction fields in
    case the transaction has reconciled splits will now only issue a
    warning. If the user continues anyway with changes to the transaction
    field the reconcile state of splits won't be affected.
    Changing protected split fields will continue to unreconcile that split.

diff --git a/gnucash/register/ledger-core/split-register-model.c b/gnucash/register/ledger-core/split-register-model.c
index e7e0a870d..3d82233f8 100644
--- a/gnucash/register/ledger-core/split-register-model.c
+++ b/gnucash/register/ledger-core/split-register-model.c
@@ -2194,9 +2194,8 @@ gnc_split_register_confirm (VirtualLocation virt_loc, gpointer user_data)
         }
         title = _("Change transaction containing a reconciled split?");
         message_format =
-         _("The transaction you are about to change is protected because it contains reconciled splits in the following accounts:\n%s"
-           "\n\nIf you continue editing this transaction all reconciled splits will be unreconciled. "
-          "This might make future reconciliation difficult! Continue with this change?");
+         _("The transaction you are about to change is contains reconciled splits in the following accounts:\n%s"
+           "\n\nAre you sure you want to continue with this change ?");
 
         message = g_strdup_printf (message_format, acc_list);
         g_free (acc_list);
@@ -2250,14 +2249,6 @@ gnc_split_register_confirm (VirtualLocation virt_loc, gpointer user_data)
             }
         }
 
-        if (protected_trans_cell)
-        {
-            if (reg->unrecn_splits != NULL)
-                g_list_free (reg->unrecn_splits);
-
-            reg->unrecn_splits = g_list_copy (xaccTransGetSplitList (trans));
-        }
-
         PINFO ("Unreconcile split list length is %d", g_list_length(reg->unrecn_splits));
         info->change_confirmed = TRUE;
     }



Summary of changes:
 gnucash/register/ledger-core/split-register-model.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)