gnucash master: [test-stress-options] fix combinatorics testing

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/fb5dd034 (commit)
	from  https://github.com/Gnucash/gnucash/commit/a9a60c18 (commit)



commit fb5dd034b790bb6e1d43d1d95796b3aa032c3a64
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue May 5 00:58:30 2020 +0800

    [test-stress-options] fix combinatorics testing
    
    Premise: pairwise combinatorics testing is only possible when all
    options have at least 2 options.
    
    The "General Journal" report is unique because it starts with the
    Transaction Report options generator, and adds a few hidden
    options. Unfortunately the Transaction Report receives the
    "General/Stylesheet" option, with only 1 default stylesheet.
    
    The General Journal report therefore has 1 stylesheet option with only
    1 choice, and is not acceptable to jenny for pairwise testing. It
    would fail the combinatorics testing. Adding other stylesheets did not
    successfully allow pairwise testing. Therefore the simplest way to
    test General Journal is to disable multichoice testing whereby
    num(choices) is only 1.

diff --git a/gnucash/report/reports/standard/test/test-stress-options.scm b/gnucash/report/reports/standard/test/test-stress-options.scm
index 5d9a92126..1240cdd38 100644
--- a/gnucash/report/reports/standard/test/test-stress-options.scm
+++ b/gnucash/report/reports/standard/test/test-stress-options.scm
@@ -65,8 +65,10 @@
             (report-options-tested '()))
        (gnc:options-for-each
         (lambda (option)
-          (when (memq (gnc:option-type option)
-                      '(multichoice boolean))
+          (when (case (gnc:option-type option)
+                  ((multichoice) (pair? (cdr (gnc:option-data option))))
+                  ((boolean) #t)
+                  (else #f))
             (set! report-options-tested
               (cons (make-combo
                      (gnc:option-section option)



Summary of changes:
 gnucash/report/reports/standard/test/test-stress-options.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)