gnucash maint: Multiple changes pushed

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/ea9eaa96 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5f90144f (commit)
	from  https://github.com/Gnucash/gnucash/commit/22a7b357 (commit)



commit ea9eaa9661891ffc64896dce57f5cca42968f716
Merge: 22a7b3571 5f90144fb
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Oct 4 11:05:59 2020 +0800

    Merge branch 'disable-report-animation' into maint #794


commit 5f90144fb17ad8a56524ed40279d0832e7c52ead
Author: Philipp Matthias Schaefer <philipp.matthias.schaefer at posteo.de>
Date:   Thu Oct 1 14:16:09 2020 +0200

    Disable initial report animation
    
    Previously, every reload caused the chart to move through an animation, which
    prevented visual comparison of state before and after reload.
    
    Also remove the now redundant line disabling animations in budget-barchart.scm.

diff --git a/gnucash/report/html-chart.scm b/gnucash/report/html-chart.scm
index d3da4b47e..359833112 100644
--- a/gnucash/report/html-chart.scm
+++ b/gnucash/report/html-chart.scm
@@ -155,6 +155,8 @@
                  (cons 'datasets #())))
     (cons 'options (list
                     (cons 'maintainAspectRatio #f)
+                    (cons 'animation (list
+                                      (cons 'duration 0)))
                     (cons 'chartArea (list
                                       (cons 'backgroundColor "#fffdf6")))
                     (cons 'legend (list
diff --git a/gnucash/report/reports/standard/budget-barchart.scm b/gnucash/report/reports/standard/budget-barchart.scm
index b61a55a0e..d6b9c4dee 100644
--- a/gnucash/report/reports/standard/budget-barchart.scm
+++ b/gnucash/report/reports/standard/budget-barchart.scm
@@ -204,8 +204,8 @@
       (gnc:html-chart-set-y-axis-label! chart (gnc-commodity-get-mnemonic curr))
 
       ;; disable animation; with multiple accounts selected this report
-      ;; will create several charts, all will want to animate
-      (gnc:html-chart-set! chart '(options animation duration) 0)
+      ;; will create several charts, all will want to animate. Initial
+      ;; animation is already disabled globally.
       (gnc:html-chart-set! chart '(options hover animationDuration) 0)
       (gnc:html-chart-set! chart '(options responsiveAnimationDuration) 0)
       (gnc:html-chart-set-title!



Summary of changes:
 gnucash/report/html-chart.scm                       | 2 ++
 gnucash/report/reports/standard/budget-barchart.scm | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)