gnucash maint: Fix missing 'Business Linked Documents' menu action.

Robert Fewell bobit at code.gnucash.org
Sun Oct 4 07:13:24 EDT 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/4afbbe13 (commit)
	from  https://github.com/Gnucash/gnucash/commit/ea9eaa96 (commit)



commit 4afbbe1348d1e6251b1eabeed02c753243e84415
Author: Robert Fewell <14uBobIT at gmail.com>
Date:   Sun Oct 4 12:11:46 2020 +0100

    Fix missing 'Business Linked Documents' menu action.

diff --git a/gnucash/gnome/gnc-plugin-business.c b/gnucash/gnome/gnc-plugin-business.c
index c0974d9c1..11e39ff8e 100644
--- a/gnucash/gnome/gnc-plugin-business.c
+++ b/gnucash/gnome/gnc-plugin-business.c
@@ -275,7 +275,7 @@ static GtkActionEntry gnc_plugin_actions [] =
 
     /* Other menu items */
     {
-        "BusinessLinkOpenAction", NULL, N_("Business Links"), NULL,
+        "BusinessLinkedDocsAction", NULL, N_("Business Linked Documents"), NULL,
         N_("View all Linked Business Documents"),
         G_CALLBACK (gnc_plugin_business_cmd_doclink)
     },
diff --git a/gnucash/gnome/gnc-plugin-page-invoice.c b/gnucash/gnome/gnc-plugin-page-invoice.c
index 68d28626a..5fd587168 100644
--- a/gnucash/gnome/gnc-plugin-page-invoice.c
+++ b/gnucash/gnome/gnc-plugin-page-invoice.c
@@ -442,7 +442,7 @@ static action_toolbar_labels creditnote_action_tooltips[] = {
     {"BlankEntryAction", N_("Move to the blank entry at the bottom of the credit note")},
     {"ToolsProcessPaymentAction", N_("Enter a payment for the owner of this credit note") },
     {"ReportsCompanyReportAction", N_("Open a company report window for the owner of this credit note") },
-    {"BusinessLinkAction", N_("_Manage Document Link...")},
+    {"BusinessLinkAction", N_("Manage Document Link...")},
     {"BusinessLinkOpenAction", N_("Open Linked Document")},
     {NULL, NULL},
 };
@@ -1376,13 +1376,12 @@ gnc_plugin_page_invoice_cmd_link (GtkAction *action,
                 gtk_link_button_set_uri (GTK_LINK_BUTTON(doclink_button),
                                          display_uri);
                 gtk_widget_show (GTK_WIDGET(doclink_button));
+                has_uri = TRUE;
                 g_free (display_uri);
             }
         }
         gncInvoiceSetDocLink (invoice, ret_uri);
-        has_uri = TRUE;
     }
-
     // update the menu actions
     update_doclink_actions (GNC_PLUGIN_PAGE(plugin_page), has_uri);
 
diff --git a/gnucash/ui/gnc-plugin-business-ui.xml b/gnucash/ui/gnc-plugin-business-ui.xml
index 361813f35..f3939abda 100644
--- a/gnucash/ui/gnc-plugin-business-ui.xml
+++ b/gnucash/ui/gnc-plugin-business-ui.xml
@@ -42,7 +42,7 @@
           <menuitem name="EmployeeProcessPayment" action="EmployeeProcessPaymentAction"/>
         </menu>
 
-        <menuitem name="BusinessLinkOpen" action="BusinessLinkOpenAction"/>
+        <menuitem name="BusinessLinkOpen" action="BusinessLinkedDocsAction"/>
 
         <placeholder name="BusinessPlaceholderTop"/>
         <separator name="Sep1"/>



Summary of changes:
 gnucash/gnome/gnc-plugin-business.c     | 2 +-
 gnucash/gnome/gnc-plugin-page-invoice.c | 5 ++---
 gnucash/ui/gnc-plugin-business-ui.xml   | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)



More information about the gnucash-changes mailing list