gnucash maint: Multiple changes pushed

Geert Janssens gjanssens at code.gnucash.org
Sat Oct 10 10:11:35 EDT 2020


Updated	 via  https://github.com/Gnucash/gnucash/commit/05c96f66 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e8c321d9 (commit)
	from  https://github.com/Gnucash/gnucash/commit/f9e1f275 (commit)



commit 05c96f66425f14654f16f55be074f6a8c413598d
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Oct 10 16:09:39 2020 +0200

    Make gnc-html's link libraries private

diff --git a/gnucash/html/CMakeLists.txt b/gnucash/html/CMakeLists.txt
index 170659246..d5b1e757e 100644
--- a/gnucash/html/CMakeLists.txt
+++ b/gnucash/html/CMakeLists.txt
@@ -51,8 +51,13 @@ add_library (gnc-html
   ${html_HEADERS}
 )
 
-target_link_libraries(gnc-html gnc-engine gnc-gnome-utils
-  PkgConfig::GTK3 PkgConfig::WEBKIT ${GUILE_LDFLAGS})
+target_link_libraries(gnc-html
+    PRIVATE
+        gnc-engine
+        gnc-gnome-utils
+        PkgConfig::GTK3
+        PkgConfig::WEBKIT
+        ${GUILE_LDFLAGS})
 
 target_compile_definitions(gnc-html PRIVATE -DG_LOG_DOMAIN=\"gnc.html\")
 

commit e8c321d954929b9a54729b4af726311c90199753
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Oct 10 12:32:53 2020 +0200

    Drop as dependency from gnc-module

diff --git a/libgnucash/gnc-module/CMakeLists.txt b/libgnucash/gnc-module/CMakeLists.txt
index 072c91de0..1a6e0a6ca 100644
--- a/libgnucash/gnc-module/CMakeLists.txt
+++ b/libgnucash/gnc-module/CMakeLists.txt
@@ -17,12 +17,11 @@ add_library	(gnc-module
   ${gnc_module_HEADERS}
 )
 
-target_link_libraries(gnc-module ${GUILE_LDFLAGS} ${GMODULE_LDFLAGS} ${GLIB2_LDFLAGS})
+target_link_libraries(gnc-module ${GMODULE_LDFLAGS} ${GLIB2_LDFLAGS})
 
 target_compile_definitions (gnc-module PRIVATE -DG_LOG_DOMAIN=\"gnc.module\")
 
 target_include_directories (gnc-module
-    PRIVATE ${GUILE_INCLUDE_DIRS}
     PUBLIC  ${CMAKE_CURRENT_SOURCE_DIR}
             ${CMAKE_SOURCE_DIR}/common
             ${CMAKE_BINARY_DIR}/common # for config.h



Summary of changes:
 gnucash/html/CMakeLists.txt          | 9 +++++++--
 libgnucash/gnc-module/CMakeLists.txt | 3 +--
 2 files changed, 8 insertions(+), 4 deletions(-)



More information about the gnucash-changes mailing list