gnucash maint: Bug 797857 - Preference Dialog to large so buttons unreachable
Robert Fewell
bobit at code.gnucash.org
Fri Sep 18 05:45:23 EDT 2020
Updated via https://github.com/Gnucash/gnucash/commit/0e9f368b (commit)
from https://github.com/Gnucash/gnucash/commit/0c71410e (commit)
commit 0e9f368b4a4083168d2875299fbeb030af33a4a8
Author: Robert Fewell <14uBobIT at gmail.com>
Date: Fri Sep 18 10:38:24 2020 +0100
Bug 797857 - Preference Dialog to large so buttons unreachable
The Preference dialog height is determined by the greater size of the
tab buttons or the number of options on the tab pages. This currently
is the 'General' tab. To reduce this, the number options have been
moved to the 'Date/Time' page and reorded.
diff --git a/gnucash/gtkbuilder/dialog-preferences.glade b/gnucash/gtkbuilder/dialog-preferences.glade
index 20cfb9049..3233c736c 100644
--- a/gnucash/gtkbuilder/dialog-preferences.glade
+++ b/gnucash/gtkbuilder/dialog-preferences.glade
@@ -883,7 +883,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">6</property>
+ <property name="top_attach">9</property>
</packing>
</child>
<child>
@@ -893,7 +893,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">5</property>
+ <property name="top_attach">8</property>
</packing>
</child>
<child>
@@ -906,7 +906,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">3</property>
+ <property name="top_attach">6</property>
</packing>
</child>
<child>
@@ -919,7 +919,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">0</property>
+ <property name="top_attach">16</property>
</packing>
</child>
<child>
@@ -929,7 +929,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">2</property>
+ <property name="top_attach">15</property>
</packing>
</child>
<child>
@@ -947,7 +947,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">1</property>
+ <property name="top_attach">17</property>
</packing>
</child>
<child>
@@ -960,7 +960,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">8</property>
+ <property name="top_attach">11</property>
</packing>
</child>
<child>
@@ -973,7 +973,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">9</property>
+ <property name="top_attach">12</property>
</packing>
</child>
<child>
@@ -992,7 +992,7 @@
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">10</property>
+ <property name="top_attach">13</property>
</packing>
</child>
<child>
@@ -1012,7 +1012,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">11</property>
+ <property name="top_attach">14</property>
</packing>
</child>
<child>
@@ -1033,7 +1033,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">1</property>
- <property name="top_attach">11</property>
+ <property name="top_attach">14</property>
</packing>
</child>
<child>
@@ -1058,11 +1058,144 @@ many months before the current month</property>
</attributes>
</child>
</object>
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="top_attach">7</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkLabel" id="label49">
+ <property name="visible">True</property>
+ <property name="can_focus">False</property>
+ <property name="halign">start</property>
+ <property name="label" translatable="yes"><b>Numbers</b></property>
+ <property name="use_markup">True</property>
+ </object>
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="top_attach">0</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkCheckButton" id="pref/general/force-price-decimal">
+ <property name="label" translatable="yes">Force P_rices to display as decimals</property>
+ <property name="visible">True</property>
+ <property name="can_focus">True</property>
+ <property name="receives_default">False</property>
+ <property name="has_tooltip">True</property>
+ <property name="tooltip_markup">Force prices to display as decimals even if they must be rounded.</property>
+ <property name="tooltip_text" translatable="yes">If active, GnuCash will round prices as necessary to display them as decimals instead of displaying the exact fraction if the fractional part cannot be exactly represented as a decimal.</property>
+ <property name="halign">start</property>
+ <property name="use_underline">True</property>
+ <property name="draw_indicator">True</property>
+ </object>
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="top_attach">1</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkCheckButton" id="pref/general/negative-in-red">
+ <property name="label" translatable="yes">Display ne_gative amounts in red</property>
+ <property name="visible">True</property>
+ <property name="can_focus">True</property>
+ <property name="receives_default">False</property>
+ <property name="has_tooltip">True</property>
+ <property name="tooltip_markup">Display negative amounts in red.</property>
+ <property name="tooltip_text" translatable="yes">Display negative amounts in red.</property>
+ <property name="halign">start</property>
+ <property name="use_underline">True</property>
+ <property name="draw_indicator">True</property>
+ </object>
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="top_attach">2</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkCheckButton" id="pref/general/auto-decimal-point">
+ <property name="label" translatable="yes">_Automatic decimal point</property>
+ <property name="visible">True</property>
+ <property name="can_focus">True</property>
+ <property name="receives_default">False</property>
+ <property name="has_tooltip">True</property>
+ <property name="tooltip_markup">Automatically insert a decimal point into values that are entered without one.</property>
+ <property name="tooltip_text" translatable="yes">Automatically insert a decimal point into values that are entered without one.</property>
+ <property name="halign">start</property>
+ <property name="use_underline">True</property>
+ <property name="draw_indicator">True</property>
+ </object>
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="top_attach">3</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkLabel" id="label17">
+ <property name="visible">True</property>
+ <property name="can_focus">False</property>
+ <property name="halign">start</property>
+ <property name="label" translatable="yes">_Decimal places</property>
+ <property name="use_underline">True</property>
+ <property name="mnemonic_widget">pref/general/auto-decimal-places</property>
+ </object>
<packing>
<property name="left_attach">0</property>
<property name="top_attach">4</property>
</packing>
</child>
+ <child>
+ <object class="GtkSpinButton" id="pref/general/auto-decimal-places">
+ <property name="visible">True</property>
+ <property name="can_focus">True</property>
+ <property name="has_tooltip">True</property>
+ <property name="tooltip_markup">How many automatic decimal places will be filled in.</property>
+ <property name="tooltip_text" translatable="yes">How many automatic decimal places will be filled in.</property>
+ <property name="invisible_char">â—</property>
+ <property name="text" translatable="yes">2</property>
+ <property name="primary_icon_activatable">False</property>
+ <property name="secondary_icon_activatable">False</property>
+ <property name="adjustment">auto_decimal_places_adj</property>
+ <property name="climb_rate">1</property>
+ <property name="value">2</property>
+ </object>
+ <packing>
+ <property name="left_attach">1</property>
+ <property name="top_attach">4</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkLabel" id="label">
+ <property name="visible">True</property>
+ <property name="can_focus">False</property>
+ </object>
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="top_attach">5</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkLabel" id="label25">
+ <property name="visible">True</property>
+ <property name="can_focus">False</property>
+ </object>
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="top_attach">10</property>
+ </packing>
+ </child>
+ <child>
+ <placeholder/>
+ </child>
+ <child>
+ <placeholder/>
+ </child>
+ <child>
+ <placeholder/>
+ </child>
+ <child>
+ <placeholder/>
+ </child>
<child>
<placeholder/>
</child>
@@ -1109,7 +1242,7 @@ many months before the current month</property>
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="halign">start</property>
- <property name="label" translatable="yes">Date/Time</property>
+ <property name="label" translatable="yes">Numbers, Date, Time</property>
</object>
<packing>
<property name="position">2</property>
@@ -1232,7 +1365,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">1</property>
- <property name="top_attach">24</property>
+ <property name="top_attach">17</property>
</packing>
</child>
<child>
@@ -1247,7 +1380,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">22</property>
+ <property name="top_attach">15</property>
</packing>
</child>
<child>
@@ -1265,7 +1398,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">16</property>
+ <property name="top_attach">9</property>
</packing>
</child>
<child>
@@ -1278,7 +1411,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">15</property>
+ <property name="top_attach">8</property>
</packing>
</child>
<child>
@@ -1291,107 +1424,6 @@ many months before the current month</property>
<property name="top_attach">13</property>
</packing>
</child>
- <child>
- <object class="GtkLabel" id="label17">
- <property name="visible">True</property>
- <property name="can_focus">False</property>
- <property name="halign">start</property>
- <property name="label" translatable="yes">_Decimal places</property>
- <property name="use_underline">True</property>
- <property name="mnemonic_widget">pref/general/auto-decimal-places</property>
- </object>
- <packing>
- <property name="left_attach">0</property>
- <property name="top_attach">13</property>
- </packing>
- </child>
- <child>
- <object class="GtkSpinButton" id="pref/general/auto-decimal-places">
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="has_tooltip">True</property>
- <property name="tooltip_markup">How many automatic decimal places will be filled in.</property>
- <property name="tooltip_text" translatable="yes">How many automatic decimal places will be filled in.</property>
- <property name="invisible_char">â—</property>
- <property name="text" translatable="yes">2</property>
- <property name="primary_icon_activatable">False</property>
- <property name="secondary_icon_activatable">False</property>
- <property name="adjustment">auto_decimal_places_adj</property>
- <property name="climb_rate">1</property>
- <property name="value">2</property>
- </object>
- <packing>
- <property name="left_attach">1</property>
- <property name="top_attach">13</property>
- </packing>
- </child>
- <child>
- <object class="GtkCheckButton" id="pref/general/auto-decimal-point">
- <property name="label" translatable="yes">_Automatic decimal point</property>
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="receives_default">False</property>
- <property name="has_tooltip">True</property>
- <property name="tooltip_markup">Automatically insert a decimal point into values that are entered without one.</property>
- <property name="tooltip_text" translatable="yes">Automatically insert a decimal point into values that are entered without one.</property>
- <property name="halign">start</property>
- <property name="use_underline">True</property>
- <property name="draw_indicator">True</property>
- </object>
- <packing>
- <property name="left_attach">0</property>
- <property name="top_attach">12</property>
- </packing>
- </child>
- <child>
- <object class="GtkCheckButton" id="pref/general/negative-in-red">
- <property name="label" translatable="yes">Display ne_gative amounts in red</property>
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="receives_default">False</property>
- <property name="has_tooltip">True</property>
- <property name="tooltip_markup">Display negative amounts in red.</property>
- <property name="tooltip_text" translatable="yes">Display negative amounts in red.</property>
- <property name="halign">start</property>
- <property name="use_underline">True</property>
- <property name="draw_indicator">True</property>
- </object>
- <packing>
- <property name="left_attach">0</property>
- <property name="top_attach">11</property>
- </packing>
- </child>
- <child>
- <object class="GtkCheckButton" id="pref/general/force-price-decimal">
- <property name="label" translatable="yes">Force P_rices to display as decimals</property>
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="receives_default">False</property>
- <property name="has_tooltip">True</property>
- <property name="tooltip_markup">Force prices to display as decimals even if they must be rounded.</property>
- <property name="tooltip_text" translatable="yes">If active, GnuCash will round prices as necessary to display them as decimals instead of displaying the exact fraction if the fractional part cannot be exactly represented as a decimal.</property>
- <property name="halign">start</property>
- <property name="use_underline">True</property>
- <property name="draw_indicator">True</property>
- </object>
- <packing>
- <property name="left_attach">0</property>
- <property name="top_attach">10</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel" id="label49">
- <property name="visible">True</property>
- <property name="can_focus">False</property>
- <property name="halign">start</property>
- <property name="label" translatable="yes"><b>Numbers</b></property>
- <property name="use_markup">True</property>
- </object>
- <packing>
- <property name="left_attach">0</property>
- <property name="top_attach">9</property>
- </packing>
- </child>
<child>
<object class="GtkLabel" id="label51">
<property name="visible">True</property>
@@ -1399,7 +1431,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">8</property>
+ <property name="top_attach">7</property>
</packing>
</child>
<child>
@@ -1412,7 +1444,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">30</property>
+ <property name="top_attach">23</property>
</packing>
</child>
<child>
@@ -1426,7 +1458,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">31</property>
+ <property name="top_attach">24</property>
</packing>
</child>
<child>
@@ -1446,7 +1478,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">1</property>
- <property name="top_attach">31</property>
+ <property name="top_attach">24</property>
</packing>
</child>
<child>
@@ -1478,7 +1510,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">18</property>
+ <property name="top_attach">11</property>
</packing>
</child>
<child>
@@ -1522,7 +1554,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">1</property>
- <property name="top_attach">18</property>
+ <property name="top_attach">11</property>
</packing>
</child>
<child>
@@ -1540,7 +1572,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">17</property>
+ <property name="top_attach">10</property>
</packing>
</child>
<child>
@@ -1550,7 +1582,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">21</property>
+ <property name="top_attach">14</property>
</packing>
</child>
<child>
@@ -1568,7 +1600,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">23</property>
+ <property name="top_attach">16</property>
</packing>
</child>
<child>
@@ -1586,7 +1618,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">24</property>
+ <property name="top_attach">17</property>
</packing>
</child>
<child>
@@ -1604,7 +1636,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">25</property>
+ <property name="top_attach">18</property>
</packing>
</child>
<child>
@@ -1621,7 +1653,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">19</property>
+ <property name="top_attach">12</property>
</packing>
</child>
<child>
@@ -1636,7 +1668,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">20</property>
+ <property name="top_attach">13</property>
</packing>
</child>
<child>
@@ -1678,7 +1710,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">1</property>
- <property name="top_attach">20</property>
+ <property name="top_attach">13</property>
</packing>
</child>
<child>
@@ -1688,7 +1720,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">26</property>
+ <property name="top_attach">19</property>
</packing>
</child>
<child>
@@ -1702,7 +1734,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">1</property>
- <property name="top_attach">28</property>
+ <property name="top_attach">21</property>
</packing>
</child>
<child>
@@ -1713,7 +1745,7 @@ many months before the current month</property>
<object class="GtkLabel" id="label20">
<property name="visible">True</property>
<property name="can_focus">False</property>
- <property name="label" translatable="yes">Path head for Linked Files Relative Paths</property>
+ <property name="label" translatable="yes">Path head for Linked Files Relative Paths</property>
<property name="use_markup">True</property>
</object>
<packing>
@@ -1737,7 +1769,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">28</property>
+ <property name="top_attach">21</property>
</packing>
</child>
<child>
@@ -1784,7 +1816,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">27</property>
+ <property name="top_attach">20</property>
</packing>
</child>
<child>
@@ -1794,7 +1826,7 @@ many months before the current month</property>
</object>
<packing>
<property name="left_attach">0</property>
- <property name="top_attach">29</property>
+ <property name="top_attach">22</property>
</packing>
</child>
<child>
@@ -1848,30 +1880,6 @@ many months before the current month</property>
<child>
<placeholder/>
</child>
- <child>
- <placeholder/>
- </child>
- <child>
- <placeholder/>
- </child>
- <child>
- <placeholder/>
- </child>
- <child>
- <placeholder/>
- </child>
- <child>
- <placeholder/>
- </child>
- <child>
- <placeholder/>
- </child>
- <child>
- <placeholder/>
- </child>
- <child>
- <placeholder/>
- </child>
</object>
<packing>
<property name="position">3</property>
Summary of changes:
gnucash/gtkbuilder/dialog-preferences.glade | 330 ++++++++++++++--------------
1 file changed, 169 insertions(+), 161 deletions(-)
More information about the gnucash-changes
mailing list